Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KNPs tests are failing with endpoint routes enabled #1585

Closed
jibi opened this issue May 8, 2023 · 3 comments
Closed

KNPs tests are failing with endpoint routes enabled #1585

jibi opened this issue May 8, 2023 · 3 comments

Comments

@jibi
Copy link
Member

jibi commented May 8, 2023

The following KNP tests:

  • client-ingress-knp
  • client-egress-knp
  • client-egress-expression-knp
  • echo-ingress-knp

are failing on latest cilium main when endpoint routes is enabled. The failures occur only when testing IPv6 connectivity.

Example run from the main cilium branch: https://github.com/cilium/cilium/actions/runs/4893888862/jobs/8737403663

To reproduce it locally:

diff --git a/Makefile b/Makefile
index 6d8a7e59ad..48fec4150e 100644
--- a/Makefile
+++ b/Makefile
@@ -524,6 +524,7 @@ kind-install-cilium: kind-ready ## Install a local Cilium version into the clust
                --chart-directory=$(ROOT_DIR)/install/kubernetes/cilium \
                --helm-values=$(ROOT_DIR)/contrib/testing/kind-values.yaml \
                --version= \
+               --nodes-without-cilium=kind-worker3 \
                >/dev/null 2>&1 &

 .PHONY: kind-uninstall-cilium
diff --git a/contrib/testing/kind-values.yaml b/contrib/testing/kind-values.yaml
index 04aa85c39b..b7dac02f03 100644
--- a/contrib/testing/kind-values.yaml
+++ b/contrib/testing/kind-values.yaml
@@ -19,9 +19,18 @@ ipv4:
   enabled: true
 bpf:
   monitorAggregation: none
+  masquerade: true
+enableIPv6Masquerade: false
 livenessProbe:
   failureThreshold: 9999
 readinessProbe:
   failureThreshold: 9999
 startupProbe:
   failureThreshold: 9999
+kubeProxyReplacement: "strict"
+tunnelProtocol: "vxlan"
+endpointRoutes:
+  enabled: true
➜  cilium git:(main) WORKERS=3 make kind && make kind-image && make kind-install-cilium
➜  cilium-cli git:(main) make && ./cilium status --wait && ./cilium connectivity test --external-from-cidrs $(kubectl get nodes kind-worker3 -o wide --no-headers | awk '{print $6}')
jibi added a commit that referenced this issue May 8, 2023
disable:
* client-ingress-knp
* echo-ingress-knp
* client-egress-knp
* client-egress-expression-knp

as the tests are currently failing with this configuration.

Issue tracked in #1585.

Signed-off-by: Gilberto Bertin <jibi@cilium.io>
@pchaigno
Copy link
Member

pchaigno commented May 8, 2023

I believe this corresponds to issues cilium/cilium#23910 and cilium/cilium#23852 upstream. cc @jschwinger233

@jschwinger233
Copy link
Member

I believe this corresponds to issues cilium/cilium#23910 and cilium/cilium#23852 upstream. cc @jschwinger233

That's right.

tklauser pushed a commit that referenced this issue May 8, 2023
disable:
* client-ingress-knp
* echo-ingress-knp
* client-egress-knp
* client-egress-expression-knp

as the tests are currently failing with this configuration.

Issue tracked in #1585.

Signed-off-by: Gilberto Bertin <jibi@cilium.io>
@brb
Copy link
Member

brb commented May 15, 2023

This got fixed by #1587.

@brb brb closed this as completed May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants