-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suite: disable KNP tests when endpoint routes and IPv6 are enabled #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
reviewed
May 8, 2023
2f378f3
to
e1c8deb
Compare
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
disable: * client-ingress-knp * echo-ingress-knp * client-egress-knp * client-egress-expression-knp as the tests are currently failing with this configuration. Issue tracked in #1585. Signed-off-by: Gilberto Bertin <jibi@cilium.io>
e1c8deb
to
bfa5e1b
Compare
gandro
approved these changes
May 8, 2023
Asking for an ack from @jschwinger233 given #1585 (comment). |
jschwinger233
approved these changes
May 8, 2023
tklauser
approved these changes
May 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable:
as the tests are currently failing with this configuration.
Issue tracked in #1585.
test run on Cilium main branch: https://github.com/cilium/cilium/actions/runs/4914096880/jobs/8775022204?pr=25194