helm mode: add additional deprecated secret logic, and fix clustermesh connect for helm mode
#1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asauber
force-pushed
the
pr/asauber/clustermesh-secretname
branch
from
b8c8fa1
to
380b63d
Compare
asauber
changed the title
asauber
changed the title
clustermesh connect for helm mode
michi-covalent
approved these changes
May 2, 2023
|
@joamaki ping! |
|
How do we trigger the required test |
Previously, we had logic to look for deprecated names like clustermesh-apiserver-client-certs when clustermesh-apiserver-client-cert was expected. With helm-based installations, we now need to also look for clustermesh-apiserver-client-cert when clustermesh-apiserver-remote-cert is expected, and do this recursively. Signed-off-by: Andrew Sauber <andrew.sauber@isovalent.com>
asauber
force-pushed
the
pr/asauber/clustermesh-secretname
branch
from
380b63d
to
127d6f9
Compare
|
@joestringer That workflow was merged since this PR was opened. I'll try a rebase. |
YutaroHayakawa
approved these changes
May 8, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
asauber
added a commit
that referenced
this pull request
May 31, 2023
As of #1551, the clustermesh connect subcommand looks for all three possible names for the clustermesh-apiserver client certificate in the local cluster. This removes the logic needed by the GKE-based CI workflow prior to that change. Signed-off-by: Andrew Sauber <andrew.sauber@isovalent.com>
tklauser
pushed a commit
that referenced
this pull request
Jun 1, 2023
As of #1551, the clustermesh connect subcommand looks for all three possible names for the clustermesh-apiserver client certificate in the local cluster. This removes the logic needed by the GKE-based CI workflow prior to that change. Signed-off-by: Andrew Sauber <andrew.sauber@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Previously, we had logic to look for deprecated names like
clustermesh-apiserver-client-certswhenclustermesh-apiserver-client-certwas expected. With helm-based installations, we now need to look forclustermesh-apiserver-client-certwhenclustermesh-apiserver-remote-certis expected.Implementation
This implements that concpet recursively, looking for the "even more deprecated" name for secrets if applicable.
Example Runs
Two example runs that exercise the logic:
Using one level of deprecated names to find the secret
Using two levels of deprecated names to find the secret