multicluster tests: simplify secret rename logic #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of #1551, the clustermesh connect subcommand looks for all three possible names for the clustermesh-apiserver client certificate in the local cluster. This removes the logic needed by the GKE-based CI workflow prior to that change. Signed-off-by: Andrew Sauber <andrew.sauber@isovalent.com>
|
Successful test run: https://github.com/cilium/cilium-cli/actions/runs/5138716964/jobs/9248337381?pr=1685 Removing the "Do Not Merge" PR enabling the test on this PR. |
asauber
force-pushed
the
pr/asauber/simplify-clustermesh-ci
branch
from
d2b5084
to
d08c88c
Compare
michi-covalent
approved these changes
Jun 1, 2023
brlbil
approved these changes
Jun 1, 2023
viktor-kurchenko
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #1551, the clustermesh connect subcommand looks for all three possible names for the clustermesh-apiserver client certificate in the local cluster.
This removes the logic needed by the GKE-based CI workflow prior to that change.