Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add slack notification step to GH actions #237

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

nebril
Copy link
Member

@nebril nebril commented May 21, 2021

Please merge this after #212 is merged, this will probably end up having conflicts, and 212 had it's share of them.

This change is pretty similar to cilium/cilium#16218

@nebril nebril temporarily deployed to ci May 21, 2021 11:40 Inactive
@kaworu kaworu added the dont-merge/blocked Another PR must be merged before this one. label May 21, 2021
@pchaigno pchaigno marked this pull request as draft May 27, 2021 14:47
@pchaigno
Copy link
Member

Marking as draft until #212 is merged. Please leave draft mode if you want reviews even before #212 is merged.

@nebril nebril removed the dont-merge/blocked Another PR must be merged before this one. label Jun 2, 2021
@nebril nebril marked this pull request as ready for review June 2, 2021 14:11
@nebril nebril requested review from a team as code owners June 2, 2021 14:11
@nebril nebril force-pushed the pr/actions-slack-notification branch from 5230520 to e1c5728 Compare June 2, 2021 14:15
@nebril nebril temporarily deployed to ci June 2, 2021 14:15 Inactive
.github/workflows/aks.yaml Outdated Show resolved Hide resolved
.github/workflows/aks.yaml Outdated Show resolved Hide resolved
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril force-pushed the pr/actions-slack-notification branch from e1c5728 to 618f3b5 Compare June 7, 2021 11:24
@nebril nebril temporarily deployed to ci June 7, 2021 11:24 Inactive
@nebril nebril requested a review from pchaigno June 7, 2021 11:51
@pchaigno
Copy link
Member

pchaigno commented Jun 7, 2021

This code should be covered by @cilium/ci-structure and @cilium/github-sec once #283 is merged. I'm a part of both, so marking as ready to merge.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 7, 2021
@nebril nebril merged commit a9f0018 into master Jun 8, 2021
@pchaigno pchaigno deleted the pr/actions-slack-notification branch June 8, 2021 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants