ci: add slack notification to GH actions #16218
Conversation
Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
This is how it looked for test PR: All messages that we are going to get from this PR are going to be failures, the passing build from screenshot above is just a test. |
|
@aanm cancellation can be caused by a timeout, which will allow us to investigate whether the timeout should be increased, or something else causing timeouts started happening. |
There was a problem hiding this comment.
This is great 🚀
Besides the cancelled() issue mentioned below, I'm a bit concerned about the number of notifications we will receive though. Where are the notifications sent? Will we receive notifications for every single check failing, in every single pull request?
nebril
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.9
in 1.9.8
maintainer-s-little-helper
bot
moved this from Backport pending to v1.9
to Backport done to v1.9
in 1.9.8
| @@ -230,3 +230,12 @@ jobs: | |||
| description: Connectivity test cancelled | |||
| state: pending | |||
| target_url: ${{ env.check_url }} | |||
|
|
|||
| - name: Send slack notification | |||
| if: ${{ (cancelled() || failure()) && (github.event_name == 'schedule' || github.event_name == 'push') }} | |||
There was a problem hiding this comment.
In cilium-cli, this was changed to !success(). Should we also make that consistent here as well? cilium/cilium-cli#237 (comment)
No description provided.