Explicitly wait for ingress service creation #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already retrieve the services at a later stage, and the pre-populated map is actually incorrect, as the namespace is not configured, causing misleading failures if not replaced. To this end, a subsequent commit will also extend the retrieval step to make sure that the service was actually created, and hence retrieved. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
Rather than just listing the services, let's explicitly wait until we successfully retrieve all expected services, so that we can provide a clear error in case something went wrong and they were not created. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
tommyp1ckles
approved these changes
Mar 22, 2024
| log.Debugf("[%s] Failed to retrieve Service %s/%s: %s", client.ClusterName(), namespace, name, err) | ||
|
|
||
| select { | ||
| case <-time.After(PollInterval): |
There was a problem hiding this comment.
Might be better to use inctimer here
There was a problem hiding this comment.
Hmm, I'd personally keep time.After for consistency with all other usages (inctimer doesn't seem to be used at all in Cilium CLI), and a global change would be out of scope here. It shouldn't matter much in terms of performance, as the CLI is not a long-running application as the Cilium agent, and it is far from being optimized in terms of memory consumption.
christarazi
approved these changes
Mar 25, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than just listing the services, let's explicitly wait until we successfully retrieve all expected services, so that we can provide a clear error in case something went wrong and they were not created.