Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly wait for ingress service creation #2445

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Explicitly wait for ingress service creation #2445

merged 2 commits into from
Mar 26, 2024

Commits on Mar 22, 2024

  1. connectivity: don't pre-populate the ingress service map 

    We already retrieve the services at a later stage, and the pre-populated
map is actually incorrect, as the namespace is not configured, causing
misleading failures if not replaced. To this end, a subsequent commit
will also extend the retrieval step to make sure that the service was
actually created, and hence retrieved.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
    @giorio94
    giorio94 committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    e0b15e7 View commit details
    Browse the repository at this point in the history

  2. connectivity: explicitly wait for ingress service creation 

    Rather than just listing the services, let's explicitly wait until we
successfully retrieve all expected services, so that we can provide a
clear error in case something went wrong and they were not created.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
    @giorio94
    giorio94 committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    36a66ff View commit details
    Browse the repository at this point in the history