sysdump: remove support for standalone hubble #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmcustodio
force-pushed
the
pr/bruno/sysdump-no-standalone-hubble
branch
from
949cdb0
to
0fff256
Compare
bmcustodio
force-pushed
the
pr/bruno/sysdump-no-standalone-hubble
branch
from
0fff256
to
9875337
Compare
tklauser
added
the
needs-rebase
|
@bmcustodio looks like this PR needs a rebase after #513 was merged. |
Standalone Hubble is pre-1.8, and hence not supported anymore. This commit removes support for dumping the daemonset + logs + etc.. Signed-off-by: Bruno Miguel Custódio <brunomcustodio@gmail.com>
tklauser
force-pushed
the
pr/bruno/sysdump-no-standalone-hubble
branch
from
9875337
to
bdba5f8
Compare
tklauser
removed
the
needs-rebase
|
Rebased and force pushed because I want to merge this before opening another PR for sysdump, i.e. to avoid merge conflicts on the new PR as well. |
tklauser
approved these changes
Sep 9, 2021
|
After quickly syncing with @michi-covalent out-of-band, it seems we still have some 1.8 users of standalone Hubble. For them it would be useful to still be able to collect standalone hubble info in their sysdump, so l'll postpone merging this PR for a bit to give them a chance to migrate. Thus moving this PR to draft for now. |
tklauser
added
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standalone Hubble is pre-1.8, and hence not supported anymore. This commit removes support for dumping the daemonset + logs + etc..