Skip to content

Commit

Permalink
workflows: consistently disabling flow validation
Browse files Browse the repository at this point in the history
[ upstream commit 36aa4f7 ]

In #16388, we disabled flow validation as it was unstable in the CLI.
In #16617, we partially moved to `warning` for testing purposes.

This reverts back to `disabled` for all connectivity tests in order to
be consistent. Also fix missing disabled flow validation in EKS, as it
seems like we missed that one in #16388.

We can always enable flow validation again later once we are confident
flow validation works better in the CLI.

Fixes 49ce8e9
Fixes 21c9b41

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Signed-off-by: André Martins <andre@cilium.io>
  • Loading branch information
nbusseneau authored and aanm committed Jul 15, 2021
1 parent ff58c32 commit 2cefd5d
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/conformance-aks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test
cilium connectivity test --flow-validation=disabled
- name: Clean up Cilium
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/conformance-eks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test
cilium connectivity test --flow-validation=disabled
- name: Clean up Cilium
run: |
Expand Down Expand Up @@ -235,7 +235,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test --force-deploy
cilium connectivity test --force-deploy --flow-validation=disabled
- name: Post-test information gathering
if: ${{ always() }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/conformance-gke.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test
cilium connectivity test --flow-validation=disabled
- name: Clean up Cilium
run: |
Expand Down Expand Up @@ -224,7 +224,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test
cilium connectivity test --flow-validation=disabled
- name: Clean up Cilium
run: |
Expand Down Expand Up @@ -258,7 +258,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test
cilium connectivity test --flow-validation=disabled
- name: Clean up Cilium
run: |
Expand Down Expand Up @@ -287,7 +287,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test --force-deploy --flow-validation=warning
cilium connectivity test --force-deploy --flow-validation=disabled
- name: Post-test information gathering
if: ${{ always() }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-kind.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test
cilium connectivity test --flow-validation=disabled
- name: Clean up Cilium
run: |
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/conformance-multicluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,8 @@ jobs:
--context ${{ steps.contexts.outputs.context1 }} \
--multi-cluster ${{ steps.contexts.outputs.context2 }} \
--test '!pod-to-nodeport' \
--test '!pod-to-local-nodeport'
--test '!pod-to-local-nodeport' \
--flow-validation=disabled
- name: Post-test information gathering
if: ${{ always() }}
Expand Down

0 comments on commit 2cefd5d

Please sign in to comment.