.github: Disable flow validation in flaky tests #16388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI
aanm
approved these changes
Jun 1, 2021
michi-covalent
approved these changes
Jun 1, 2021
christarazi
approved these changes
Jun 1, 2021
The flow validation of cilium connectivity test has been reported to be flaky in several of the ci-xxx tests [1, 2, 3]. To reduce CI noise, we can disable flow validation until the flakes are fixed. 1 - cilium#16292. 2 - cilium#16291. 3 - cilium#16096. Signed-off-by: Paul Chaignon <paul@cilium.io>
|
I updated the branch to also disable in the Kind1.19 test given it's also failing there (cf. #16392). |
pchaigno
force-pushed
the
disable-flow-validation
branch
from
e798d6c
to
a5b54a7
Compare
|
EDIT: That's just because these tests execute the master versions on PR 🤦 |
|
Al team reviews are covered. The Kind1.19 test is passing. Other triggered tests are running the master version, not this PR version. Marking as ready to merge. |
pchaigno
added
the
ready-to-merge
nathanjsweet
approved these changes
Jun 2, 2021
There was a problem hiding this comment.
@pchaigno can you validate that the client-to-client-client-ingress-from-client test in the aks conformance tests has nothing to do with this PR? Otherwise LGTM.
NVM, didn't see the previous comment
nebril
pushed a commit
to nbusseneau/cilium
that referenced
this pull request
Jun 23, 2021
Seems like we missed that in cilium#16388. Fixes 49ce8e9 Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
added a commit
to nbusseneau/cilium
that referenced
this pull request
Jun 29, 2021
Seems like we missed that in cilium#16388. Fixes 49ce8e9 Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
added a commit
that referenced
this pull request
Jul 5, 2021
In #16388, we disabled flow validation as it was unstable in the CLI. In #16617, we partially moved to `warning` for testing purposes. This reverts back to `disabled` for all connectivity tests in order to be consistent. Also fix missing disabled flow validation in EKS, as it seems like we missed that one in #16388. We can always enable flow validation again later once we are confident flow validation works better in the CLI. Fixes 49ce8e9 Fixes 21c9b41 Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
nbusseneau
added a commit
that referenced
this pull request
Jul 7, 2021
In #16388, we disabled flow validation as it was unstable in the CLI. In #16617, we partially moved to `warning` for testing purposes. This reverts back to `disabled` for all connectivity tests in order to be consistent. Also fix missing disabled flow validation in EKS, as it seems like we missed that one in #16388. We can always enable flow validation again later once we are confident flow validation works better in the CLI. Fixes 49ce8e9 Fixes 21c9b41 Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
kkourt
pushed a commit
that referenced
this pull request
Jul 8, 2021
In #16388, we disabled flow validation as it was unstable in the CLI. In #16617, we partially moved to `warning` for testing purposes. This reverts back to `disabled` for all connectivity tests in order to be consistent. Also fix missing disabled flow validation in EKS, as it seems like we missed that one in #16388. We can always enable flow validation again later once we are confident flow validation works better in the CLI. Fixes 49ce8e9 Fixes 21c9b41 Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
aanm
pushed a commit
that referenced
this pull request
Jul 15, 2021
[ upstream commit 36aa4f7 ] In #16388, we disabled flow validation as it was unstable in the CLI. In #16617, we partially moved to `warning` for testing purposes. This reverts back to `disabled` for all connectivity tests in order to be consistent. Also fix missing disabled flow validation in EKS, as it seems like we missed that one in #16388. We can always enable flow validation again later once we are confident flow validation works better in the CLI. Fixes 49ce8e9 Fixes 21c9b41 Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com> Signed-off-by: André Martins <andre@cilium.io>
aanm
pushed a commit
that referenced
this pull request
Jul 15, 2021
[ upstream commit 36aa4f7 ] In #16388, we disabled flow validation as it was unstable in the CLI. In #16617, we partially moved to `warning` for testing purposes. This reverts back to `disabled` for all connectivity tests in order to be consistent. Also fix missing disabled flow validation in EKS, as it seems like we missed that one in #16388. We can always enable flow validation again later once we are confident flow validation works better in the CLI. Fixes 49ce8e9 Fixes 21c9b41 Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com> Signed-off-by: André Martins <andre@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flow validation of cilium connectivity test has been reported to be flaky in several of the
ci-xxxtests [1, 2, 3, 4]. To reduce CI noise, we can disable flow validation until the flakes are fixed.1 - #16292.
2 - #16291.
3 - #16096.
4 - #16392.