Skip to content

Commit

Permalink
workflows: consistently disabling flow validation
Browse files Browse the repository at this point in the history
In #16388, we disabled flow validation as it was unstable in the CLI.
In #16617, we partially moved to `warning` for testing purposes.

This reverts back to `disabled` for all connectivity tests in order to
be consistent. Also fix missing disabled flow validation in EKS, as it
seems like we missed that one in #16388.

We can always enable flow validation again later once we are confident
flow validation works better in the CLI.

Fixes 49ce8e9
Fixes 21c9b41

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
  • Loading branch information
nbusseneau committed Jul 7, 2021
1 parent c9839cc commit f98a99d
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/conformance-aks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test --flow-validation=warning
cilium connectivity test --flow-validation=disabled
- name: Clean up Cilium
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-aws-cni.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test \
--flow-validation=warning \
--flow-validation=disabled \
--test '!pod-to-world-toFQDNs' # L7 policies are not supported in chaining mode.
- name: Post-test information gathering
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/conformance-eks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test --flow-validation=warning
cilium connectivity test --flow-validation=disabled
- name: Clean up Cilium
run: |
Expand Down Expand Up @@ -259,7 +259,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test --force-deploy
cilium connectivity test --force-deploy --flow-validation=disabled
- name: Post-test information gathering
if: ${{ failure() }}
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/conformance-gke.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test --flow-validation=warning
cilium connectivity test --flow-validation=disabled
- name: Clean up Cilium
run: |
Expand Down Expand Up @@ -244,7 +244,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test --flow-validation=warning
cilium connectivity test --flow-validation=disabled
- name: Clean up Cilium
run: |
Expand Down Expand Up @@ -282,7 +282,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test --flow-validation=warning
cilium connectivity test --flow-validation=disabled
- name: Clean up Cilium
run: |
Expand Down Expand Up @@ -311,7 +311,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test --force-deploy --flow-validation=warning
cilium connectivity test --force-deploy --flow-validation=disabled
- name: Post-test information gathering
if: ${{ failure() }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-kind.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
- name: Run connectivity test
run: |
cilium connectivity test --flow-validation=warning
cilium connectivity test --flow-validation=disabled
- name: Clean up Cilium
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/conformance-multicluster.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ jobs:
--multi-cluster ${{ steps.contexts.outputs.context2 }} \
--test '!pod-to-nodeport' \
--test '!pod-to-local-nodeport' \
--flow-validation=warning
--flow-validation=disabled
- name: Post-test information gathering
if: ${{ failure() }}
Expand Down

0 comments on commit f98a99d

Please sign in to comment.