Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable staticcheck as part of build #11527

Closed
sayboras opened this issue May 14, 2020 · 1 comment · Fixed by #11528
Closed

Enable staticcheck as part of build #11527

sayboras opened this issue May 14, 2020 · 1 comment · Fixed by #11528
Assignees
@sayboras
Labels
kind/feature This introduces new functionality.

Comments

@sayboras
Copy link
Member

I noticed that there were some PR to address staticcheck issue regularly

#11390
#10858
#10085
#7884

It will be better to enforce this as part of PR build I think. As disccussed on slack, we can enable some basic linters such as staticcheck, gofmt, govet, ineffassign as starting point.
@sayboras sayboras added the kind/feature This introduces new functionality. label May 14, 2020
@sayboras sayboras mentioned this issue May 14, 2020
Merged
@vadorovsky
Copy link
Member

I see that you are working on it, so I'm assigning you. ;)

sayboras added a commit to sayboras/cilium that referenced this issue Jun 19, 2020
@sayboras
chore(lint): To add golangci-lint gh action to perform lint check
edb79ce 
As discussed in slack, we can start with few basic linters staticcheck,
govet, gofmt and ineffassign. This is a starting point, we can improvise
as we are going.

+ Rename ineffassign Makefile target by lint
+ Remove ineffassign as it's embeded by golangci-lint binary
+ Remove un-used badkeys slice in cilium/cmd/preflight_identity_crd_migrate.go
+ Install golangci-lint in travis script
+ Revert the changes in cilium#11987

Fixes cilium#11527

Signed-off-by: Tam Mach <sayboras@yahoo.com>
sayboras added a commit to sayboras/cilium that referenced this issue Jul 1, 2020
@sayboras
chore(lint): To add golangci-lint gh action to perform lint check
fe0da22 
As discussed in slack, we can start with few basic linters staticcheck,
govet, gofmt and ineffassign. This is a starting point, we can improvise
as we are going.

+ Rename ineffassign Makefile target by lint
+ Remove ineffassign as it's embeded by golangci-lint binary
+ Remove un-used badkeys slice in cilium/cmd/preflight_identity_crd_migrate.go
+ Install golangci-lint in travis script
+ Revert the changes in cilium#11987

Fixes cilium#11527

Signed-off-by: Tam Mach <sayboras@yahoo.com>
aanm pushed a commit that referenced this issue Jul 2, 2020
@sayboras @aanm
chore(lint): To add golangci-lint gh action to perform lint check
e75d4a6 
As discussed in slack, we can start with few basic linters staticcheck,
govet, gofmt and ineffassign. This is a starting point, we can improvise
as we are going.

+ Rename ineffassign Makefile target by lint
+ Remove ineffassign as it's embeded by golangci-lint binary
+ Remove un-used badkeys slice in cilium/cmd/preflight_identity_crd_migrate.go
+ Install golangci-lint in travis script
+ Revert the changes in #11987

Fixes #11527

Signed-off-by: Tam Mach <sayboras@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sayboras sayboras

Labels
kind/feature This introduces new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(lint): To add golangci-lint gh action to perform lint check sayboras/cilium
2 participants
@sayboras @vadorovsky