Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: remove unnecessary use of fmt.Sprintf #10858

Merged
merged 1 commit into from Apr 6, 2020
Merged

all: remove unnecessary use of fmt.Sprintf #10858

merged 1 commit into from Apr 6, 2020

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Apr 6, 2020

Found using staticcheck -checks S1039 ./...

@tklauser
all: remove unnecessary use of fmt.Sprintf
e31cb3a 
Found using `staticcheck -checks S1039 ./...`

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added pending-review kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Apr 6, 2020
@tklauser tklauser requested review from a team April 6, 2020 09:12
@tklauser tklauser requested review from a team as code owners April 6, 2020 09:12
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 6, 2020
@tklauser
Copy link
Member Author

tklauser commented Apr 6, 2020

test-me-please

aanm
aanm approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 45.916% when pulling e31cb3a on pr/tklauser/unnecessary-sprintf into c3dee35 on master.

@tgraf tgraf merged commit 9ff51d2 into master Apr 6, 2020
1.8.0 automation moved this from In progress to Merged Apr 6, 2020
@tgraf tgraf deleted the pr/tklauser/unnecessary-sprintf branch April 6, 2020 15:27
@sayboras sayboras mentioned this pull request May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@aanm aanm aanm approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tklauser @coveralls @pchaigno @aanm @qmonnet @tgraf