Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up hostscope-legacy ipam option #12974

Closed
sayboras opened this issue Aug 26, 2020 · 2 comments · Fixed by #12984
Closed

Clean up hostscope-legacy ipam option #12974

sayboras opened this issue Aug 26, 2020 · 2 comments · Fixed by #12984
Labels
good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. help-wanted Please volunteer for this by adding yourself as an assignee! kind/cleanup This includes no functional changes.

Comments

@sayboras
Copy link
Member

Related to https://github.com/cilium/cilium/blob/master/pkg/ipam/option/option.go#L18-L20
@sayboras sayboras added help-wanted Please volunteer for this by adding yourself as an assignee! good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. kind/cleanup This includes no functional changes. labels Aug 26, 2020
@sayboras
Copy link
Member Author

@tklauser just want to check with you if we can remove this option for 1.9 preparation. Currently, this hostscope-legacy is still used as default value, will the new default value for ipam option be cluster-pool ? Thanks.

@tklauser
Copy link
Member

I'm not entirely sure what the new default options should be as I'm not terribly familiar with the different IPAM modes. FWIW, this was deprecated in #10407, so pinging @tgraf and @aanm who might be able to say more.

@sayboras sayboras mentioned this issue Aug 27, 2020
Merged
2 tasks
sayboras added a commit to sayboras/cilium that referenced this issue Sep 4, 2020
@sayboras
cleanup/ipam: Remove hostscope-legacy IPAM option
17bb9d1 
To remove hostscope-legacy IPAM option

Fixes: cilium#12974

Signed-off-by: Tam Mach <sayboras@yahoo.com>
sayboras added a commit to sayboras/cilium that referenced this issue Sep 5, 2020
@sayboras
cleanup/ipam: Remove hostscope-legacy IPAM option
00ba9f0 
To remove hostscope-legacy IPAM option

Fixes: cilium#12974

Signed-off-by: Tam Mach <sayboras@yahoo.com>
aanm pushed a commit that referenced this issue Sep 7, 2020
@sayboras @aanm
cleanup/ipam: Remove hostscope-legacy IPAM option
175bd96 
To remove hostscope-legacy IPAM option

Fixes: #12974

Signed-off-by: Tam Mach <sayboras@yahoo.com>
@gandro gandro mentioned this issue Nov 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. help-wanted Please volunteer for this by adding yourself as an assignee! kind/cleanup This includes no functional changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup/ipam: Remove hostscope-legacy IPAM option sayboras/cilium
2 participants
@tklauser @sayboras