Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: extraHostPathMounts sets hostPath.path wrongly #14132

Closed
errordeveloper opened this issue Nov 23, 2020 · 0 comments · Fixed by #14134
Closed

helm: extraHostPathMounts sets hostPath.path wrongly #14132

errordeveloper opened this issue Nov 23, 2020 · 0 comments · Fixed by #14134
Assignees
@errordeveloper
Labels
area/helm Impacts helm charts and user deployment experience kind/bug This is a bug in the Cilium logic.

Comments

@errordeveloper
Copy link
Contributor

errordeveloper commented Nov 23, 2020 •
edited
Loading

With #13210 new parameter was added to agent and operator pods - extraHostPathMounts.

Present implementation mis-references hostPath:

cilium/install/kubernetes/cilium/templates/cilium-agent-daemonset.yaml

Lines 446 to 450 in dcda3fd

{{- range .Values.extraHostPathMounts }}
- name: {{ .name }}
hostPath:
path: {{ .mountPath }}
{{- end }}

Instead, it should be this:

      - name: {{ .name }}
        hostPath:
          path: {{ .hostPath }

xref #14133
@errordeveloper errordeveloper added needs-backport/1.9 area/helm Impacts helm charts and user deployment experience kind/bug This is a bug in the Cilium logic. labels Nov 23, 2020
@errordeveloper errordeveloper self-assigned this Nov 23, 2020
errordeveloper added a commit that referenced this issue Nov 23, 2020
@errordeveloper
helm: fix and improve extraHostPathMounts for agent and operator
7ecf76d 
- fix reference for host-side path, use `hostPath` instead of `mountPath`
- add `type`

Fixes: #14132

Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
@errordeveloper errordeveloper mentioned this issue Nov 23, 2020
Merged
errordeveloper added a commit that referenced this issue Nov 24, 2020
@errordeveloper
helm: fix and improve extraHostPathMounts for agent and operator
a602cdf 
- fix reference for host-side path, use `hostPath` instead of `mountPath`
- add `type`

Fixes: #14132

Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
errordeveloper added a commit that referenced this issue Nov 24, 2020
@errordeveloper
helm: fix and improve extraHostPathMounts for agent and operator
625f82d 
- fix reference for host-side path, use `hostPath` instead of `mountPath`
- add `type`

Fixes: #14132

Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
aanm pushed a commit that referenced this issue Nov 30, 2020
@errordeveloper @aanm
helm: fix and improve extraHostPathMounts for agent and operator
5a8063a 
[ upstream commit 625f82d ]

- fix reference for host-side path, use `hostPath` instead of `mountPath`
- add `type`

Fixes: #14132

Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
Signed-off-by: André Martins <andre@cilium.io>
aanm pushed a commit that referenced this issue Dec 2, 2020
@errordeveloper @aanm
helm: fix and improve extraHostPathMounts for agent and operator
cba6d38 
[ upstream commit 625f82d ]

- fix reference for host-side path, use `hostPath` instead of `mountPath`
- add `type`

Fixes: #14132

Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
Signed-off-by: André Martins <andre@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@errordeveloper errordeveloper

Labels
area/helm Impacts helm charts and user deployment experience kind/bug This is a bug in the Cilium logic.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

helm: fix usage of hostPath and add hostPathType in extraHostPathMounts cilium/cilium
1 participant
@errordeveloper