-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: fix usage of hostPath
and add hostPathType
in extraHostPathMounts
#14134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR doesn't touch unimplemented usage of |
- fix reference for host-side path, use `hostPath` instead of `mountPath` - add `type` Fixes: #14132 Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
7ecf76d
to
a602cdf
Compare
kaworu
approved these changes
Nov 24, 2020
install/kubernetes/cilium/templates/cilium-agent-daemonset.yaml
Outdated
Show resolved
Hide resolved
install/kubernetes/cilium/templates/cilium-operator-deployment.yaml
Outdated
Show resolved
Hide resolved
install/kubernetes/cilium/templates/cilium-operator-deployment.yaml
Outdated
Show resolved
Hide resolved
nit: I don't find the PR's title clear enough as release note. |
fristonio
approved these changes
Nov 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
extraHostPathMounts
for agent and operatorextraHostPathMounts
and parametrise hostPath.type
qmonnet
approved these changes
Nov 24, 2020
extraHostPathMounts
and parametrise hostPath.type
hostPath
and add hostPathType
in extraHostPathMounts
None of test exercise this path, but I have done quite a manual tests just now, so merging comfortably. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/helm
Impacts helm charts and user deployment experience
kind/bug
This is a bug in the Cilium logic.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/minor
This PR changes functionality that users may find relevant to operating Cilium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hostPath
instead ofmountPath
type
Fixes: #14132