Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: fix usage of hostPath and add hostPathType in extraHostPathMounts #14134

Merged
merged 1 commit into from
Nov 24, 2020
Merged

helm: fix usage of hostPath and add hostPathType in extraHostPathMounts #14134

merged 1 commit into from
Nov 24, 2020

Conversation

errordeveloper
Copy link
Contributor

  • fix reference for host-side path, use hostPath instead of mountPath
  • add type

Fixes: #14132

@errordeveloper errordeveloper added kind/bug This is a bug in the Cilium logic. area/helm Impacts helm charts and user deployment experience needs-backport/1.9 labels Nov 23, 2020
@errordeveloper errordeveloper requested review from a team as code owners November 23, 2020 17:24
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 23, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.10.0 Nov 23, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.1 Nov 23, 2020
@errordeveloper
Copy link
Contributor Author

This PR doesn't touch unimplemented usage of extraHostPathMounts, which is in scope for #14133.

@errordeveloper errordeveloper added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Nov 23, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 23, 2020
@errordeveloper
helm: fix and improve extraHostPathMounts for agent and operator
a602cdf 
- fix reference for host-side path, use `hostPath` instead of `mountPath`
- add `type`

Fixes: #14132

Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
@kaworu
Copy link
Member

kaworu commented Nov 24, 2020

nit: I don't find the PR's title clear enough as release note.

fristonio
fristonio approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@fristonio fristonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@errordeveloper errordeveloper changed the title helm: fix and improve extraHostPathMounts for agent and operator helm: fix bug in extraHostPathMounts and parametrise hostPath.type Nov 24, 2020
@qmonnet qmonnet removed their assignment Nov 24, 2020
@errordeveloper errordeveloper added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 24, 2020
@errordeveloper errordeveloper changed the title helm: fix bug in extraHostPathMounts and parametrise hostPath.type helm: fix usage of hostPath and add hostPathType in extraHostPathMounts Nov 24, 2020
@errordeveloper
Copy link
Contributor Author

None of test exercise this path, but I have done quite a manual tests just now, so merging comfortably.

@errordeveloper errordeveloper merged commit 625f82d into master Nov 24, 2020
@errordeveloper errordeveloper deleted the pr/errordeveloper/fix-14132 branch November 24, 2020 15:19
@errordeveloper errordeveloper mentioned this pull request Nov 24, 2020
Merged
@aanm aanm mentioned this pull request Nov 30, 2020
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.1 Nov 30, 2020
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.1 Dec 2, 2020
@aanm aanm mentioned this pull request Dec 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@qmonnet qmonnet qmonnet approved these changes

@fristonio fristonio fristonio approved these changes

@seanmwinn seanmwinn Awaiting requested review from seanmwinn

@nathanjsweet nathanjsweet Awaiting requested review from nathanjsweet

Assignees

@nathanjsweet nathanjsweet

@seanmwinn seanmwinn

Labels
area/helm Impacts helm charts and user deployment experience kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.10.0
Done
1.9.1
Backport done to v1.9
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm: extraHostPathMounts sets hostPath.path wrongly
7 participants
@errordeveloper @kaworu @qmonnet @fristonio @nathanjsweet @aanm @seanmwinn