Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Minor] datapath log format improvement #17506

Closed
leonliao opened this issue Sep 30, 2021 · 1 comment · Fixed by #17507
Closed

[Minor] datapath log format improvement #17506

leonliao opened this issue Sep 30, 2021 · 1 comment · Fixed by #17507
Labels
area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. kind/bug This is a bug in the Cilium logic.

Comments

@leonliao
Copy link
Contributor

Bug report

General Information

How to reproduce the issue

  1. cilium monitor -vv with settings of cilium agent:
debug: "true"
debug-verbose: "datapath"
  1. The traffic log shows
    CPU 01: MARK 0x0 FROM 3103 to-proxy: 66 bytes (66 captured), state established, interface lxcb40932b0a2c5identity 30168->30747, orig-ip 10.0.1.169.
    There should be a comma and space before identity, making the log to be
    CPU 01: MARK 0x0 FROM 3103 to-proxy: 66 bytes (66 captured), state established, interface lxcb40932b0a2c5, identity 30168->30747, orig-ip 10.0.1.169.
@leonliao leonliao added the kind/bug This is a bug in the Cilium logic. label Sep 30, 2021
@pchaigno
Copy link
Member

The problematic code is located here:

cilium/pkg/monitor/datapath_drop.go

Line 63 in a8e3fa2

n.dumpIdentity(buf, numeric)
and here:

cilium/pkg/monitor/datapath_trace.go

Line 219 in cebd290

n.dumpIdentity(buf, numeric)

Could you send a fix?

@pchaigno pchaigno added area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. labels Sep 30, 2021
leonliao added a commit to leonliao/cilium that referenced this issue Sep 30, 2021
@leonliao
monitor: Improve the log output format of datapath log.
de4b91d 
Adds comma and space between interface name and identity.
Fixes cilium#17506
Signed-off-by: Xiaobo Liao <xiaobo.liao@gmail.com>
@leonliao leonliao mentioned this issue Sep 30, 2021
Merged
6 tasks
aanm pushed a commit that referenced this issue Oct 12, 2021
@leonliao @aanm
monitor: Improve the log output format of datapath log.
ff60b5b 
Adds comma and space between interface name and identity.
Fixes #17506
Signed-off-by: Xiaobo Liao <xiaobo.liao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/monitor Impacts monitoring, access logging, flow logging, visibility of datapath traffic. good-first-issue Good starting point for new developers, which requires minimal understanding of Cilium. kind/bug This is a bug in the Cilium logic.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

monitor: Improve the log output format of datapath log. leonliao/cilium
2 participants
@leonliao @pchaigno