Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monitor: Improve the log output format of datapath log. #17507

Merged
merged 1 commit into from Oct 12, 2021
Merged

monitor: Improve the log output format of datapath log. #17507

merged 1 commit into from Oct 12, 2021

Conversation

leonliao
Copy link
Contributor

Adds comma and space between interface name and identity.
Fixes #17506

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Fixes: #17506

@leonliao
monitor: Improve the log output format of datapath log.
de4b91d 
Adds comma and space between interface name and identity.
Fixes cilium#17506
Signed-off-by: Xiaobo Liao <xiaobo.liao@gmail.com>
@leonliao leonliao requested a review from a team September 30, 2021 11:28
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Sep 30, 2021
@aanm
Copy link
Member

aanm commented Oct 2, 2021

/test

@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Oct 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 2, 2021
kkourt
kkourt approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aanm aanm merged commit ff60b5b into cilium:master Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkourt kkourt kkourt approved these changes

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Minor] datapath log format improvement
4 participants
@leonliao @aanm @kkourt @christarazi