Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cilium: Removed stale bpf map info messages on L4LB-only maps #17935

Closed
borkmann opened this issue Nov 19, 2021 · 0 comments · Fixed by #17973
Closed

cilium: Removed stale bpf map info messages on L4LB-only maps #17935

borkmann opened this issue Nov 19, 2021 · 0 comments · Fixed by #17973
Assignees
@borkmann
Labels
kind/bug This is a bug in the Cilium logic. release-blocker/1.11 This issue will prevent the release of the next version of Cilium.

Comments

@borkmann
Copy link
Member

borkmann commented Nov 19, 2021 •
edited

What happened?

These should not be created in the first place when running in CNI mode given they belong to L4LB:

 k8sPodName=/ subsys=endpoint
level=info msg="Restored endpoint" endpointID=3747 ipAddr="[ ]" subsys=endpoint
level=info msg="Finished regenerating restored endpoints" regenerated=1 subsys=daemon total=1
level=info msg="Removed stale bpf map" file-path=/sys/fs/bpf/tc/globals/cilium_capture_cache subsys=daemon
level=info msg="Removed stale bpf map" file-path=/sys/fs/bpf/tc/globals/cilium_ktime_cache subsys=daemon
@borkmann borkmann added kind/bug This is a bug in the Cilium logic. release-blocker/1.11 This issue will prevent the release of the next version of Cilium. labels Nov 19, 2021
@borkmann borkmann self-assigned this Nov 22, 2021
borkmann added a commit that referenced this issue Nov 23, 2021
@borkmann
bpf: Fix l4lb stale map removal under cni mode
db084fe 
When the agent starts up we can see the following maps being removed as
stale maps:

  [...]
  level=info msg="Restored endpoint" endpointID=3747 ipAddr="[ ]" subsys=endpoint
  level=info msg="Finished regenerating restored endpoints" regenerated=1 subsys=daemon total=1
  level=info msg="Removed stale bpf map" file-path=/sys/fs/bpf/tc/globals/cilium_capture_cache subsys=daemon
  level=info msg="Removed stale bpf map" file-path=/sys/fs/bpf/tc/globals/cilium_ktime_cache subsys=daemon
  [...]

This is due to pcap.h being included from nodeport.h where the former
defines mentioned maps unconditionally. Rework it, so that both are
only created in L4LB mode.

Fixes: #17935
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann mentioned this issue Nov 23, 2021
Merged
borkmann added a commit that referenced this issue Nov 23, 2021
@borkmann
bpf: Fix l4lb stale map removal under cni mode
cb1bf90 
When the agent starts up we can see the following maps being removed as
stale maps:

  [...]
  level=info msg="Restored endpoint" endpointID=3747 ipAddr="[ ]" subsys=endpoint
  level=info msg="Finished regenerating restored endpoints" regenerated=1 subsys=daemon total=1
  level=info msg="Removed stale bpf map" file-path=/sys/fs/bpf/tc/globals/cilium_capture_cache subsys=daemon
  level=info msg="Removed stale bpf map" file-path=/sys/fs/bpf/tc/globals/cilium_ktime_cache subsys=daemon
  [...]

This is due to pcap.h being included from nodeport.h where the former
defines mentioned maps unconditionally. Rework it, so that both are
only created in L4LB mode.

Fixes: #17935
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
qmonnet pushed a commit to qmonnet/cilium that referenced this issue Nov 29, 2021
@borkmann @qmonnet
bpf: Fix l4lb stale map removal under cni mode
3f0c75a 
[ upstream commit cb1bf90 ]

When the agent starts up we can see the following maps being removed as
stale maps:

  [...]
  level=info msg="Restored endpoint" endpointID=3747 ipAddr="[ ]" subsys=endpoint
  level=info msg="Finished regenerating restored endpoints" regenerated=1 subsys=daemon total=1
  level=info msg="Removed stale bpf map" file-path=/sys/fs/bpf/tc/globals/cilium_capture_cache subsys=daemon
  level=info msg="Removed stale bpf map" file-path=/sys/fs/bpf/tc/globals/cilium_ktime_cache subsys=daemon
  [...]

This is due to pcap.h being included from nodeport.h where the former
defines mentioned maps unconditionally. Rework it, so that both are
only created in L4LB mode.

Fixes: cilium#17935
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Quentin Monnet <quentin@isovalent.com>
aanm pushed a commit that referenced this issue Nov 30, 2021
@borkmann @aanm
bpf: Fix l4lb stale map removal under cni mode
6b54b83 
[ upstream commit cb1bf90 ]

When the agent starts up we can see the following maps being removed as
stale maps:

  [...]
  level=info msg="Restored endpoint" endpointID=3747 ipAddr="[ ]" subsys=endpoint
  level=info msg="Finished regenerating restored endpoints" regenerated=1 subsys=daemon total=1
  level=info msg="Removed stale bpf map" file-path=/sys/fs/bpf/tc/globals/cilium_capture_cache subsys=daemon
  level=info msg="Removed stale bpf map" file-path=/sys/fs/bpf/tc/globals/cilium_ktime_cache subsys=daemon
  [...]

This is due to pcap.h being included from nodeport.h where the former
defines mentioned maps unconditionally. Rework it, so that both are
only created in L4LB mode.

Fixes: #17935
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@borkmann borkmann

Labels
kind/bug This is a bug in the Cilium logic. release-blocker/1.11 This issue will prevent the release of the next version of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bpf: Fix stale map removal in agent logs cilium/cilium
1 participant
@borkmann