bpf: Fix stale map removal in agent logs #17973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces scope to where it is really used given this creates a map. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
When the agent starts up we can see the following maps being removed as stale maps: [...] level=info msg="Restored endpoint" endpointID=3747 ipAddr="[ ]" subsys=endpoint level=info msg="Finished regenerating restored endpoints" regenerated=1 subsys=daemon total=1 level=info msg="Removed stale bpf map" file-path=/sys/fs/bpf/tc/globals/cilium_capture_cache subsys=daemon level=info msg="Removed stale bpf map" file-path=/sys/fs/bpf/tc/globals/cilium_ktime_cache subsys=daemon [...] This is due to pcap.h being included from nodeport.h where the former defines mentioned maps unconditionally. Rework it, so that both are only created in L4LB mode. Fixes: #17935 Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
borkmann
added
sig/datapath
|
/test Job 'Cilium-PR-K8s-1.22-kernel-4.9' failed and has not been observed before, so may be related to your PR: Click to show.Test NameFailure OutputIf it is a flake, comment |
|
/mlh new-flake Cilium-PR-K8s-1.22-kernel-4.9 👍 created #17981 |
|
test-1.22-4.9 |
pchaigno
approved these changes
Nov 23, 2021
|
test-1.22-4.9 Job 'Cilium-PR-K8s-1.22-kernel-4.9' failed and has not been observed before, so may be related to your PR: Click to show.Test NameFailure OutputIf it is a flake, comment |
joestringer
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.11
in 1.11.0
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.11
in 1.11.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit msg.
Fixes: #17935