Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly improve UX around passing --metrics #22888

Merged
merged 2 commits into from Jan 5, 2023
Merged

Slightly improve UX around passing --metrics #22888

merged 2 commits into from Jan 5, 2023

Conversation

christarazi
Copy link
Member

  • metrics: Add default case for catching unknown metrics
  • daemon, install: Clarify how to pass --metrics

@christarazi christarazi added area/daemon Impacts operation of the Cilium daemon. area/metrics Impacts statistics / metrics gathering, eg via Prometheus. kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact. labels Dec 28, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Dec 28, 2022
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Dec 28, 2022
@christarazi christarazi removed the kind/community-contribution This was a contribution made by a community member. label Dec 28, 2022
@christarazi christarazi changed the title pr/christarazi/improve metrics ux Slightly improve UX around passing --metrics Dec 28, 2022
@christarazi christarazi force-pushed the pr/christarazi/improve-metrics-ux branch from a1f1196 to 3d0622b Compare January 4, 2023 06:31
@christarazi
Copy link
Member Author

/test

@christarazi christarazi force-pushed the pr/christarazi/improve-metrics-ux branch from 3d0622b to ff3e286 Compare January 4, 2023 19:43
@christarazi
metrics: Add default case for catching unknown metrics
bc78b83 
This is useful for pointing out mistakes / typos when configuring
metrics. If a user inputs an unknown metric, this warning should help
the user realize their mistake.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi
daemon, install: Clarify how to pass --metrics
fecd427 
It wasn't clear that Cilium expects the string passed to --metrics to be
separated by a space when multiple metric names are passed. Clarify it
in the help msg.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi force-pushed the pr/christarazi/improve-metrics-ux branch from ff3e286 to fecd427 Compare January 4, 2023 19:43
@christarazi christarazi marked this pull request as ready for review January 4, 2023 19:44
@christarazi christarazi requested review from a team as code owners January 4, 2023 19:44
@christarazi
Copy link
Member Author

/test

@christarazi christarazi mentioned this pull request Jan 4, 2023
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 5, 2023
@aditighag aditighag merged commit 2a5959e into cilium:master Jan 5, 2023
@christarazi christarazi deleted the pr/christarazi/improve-metrics-ux branch January 5, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
area/daemon Impacts operation of the Cilium daemon. area/metrics Impacts statistics / metrics gathering, eg via Prometheus. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christarazi @sayboras @aditighag