-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slightly improve UX around passing --metrics
#22888
Merged
aditighag
merged 2 commits into
cilium:master
from
christarazi:pr/christarazi/improve-metrics-ux
Jan 5, 2023
Merged
Slightly improve UX around passing --metrics
#22888
aditighag
merged 2 commits into
cilium:master
from
christarazi:pr/christarazi/improve-metrics-ux
Jan 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
christarazi
commented
Dec 28, 2022
- metrics: Add default case for catching unknown metrics
- daemon, install: Clarify how to pass --metrics
christarazi
added
area/daemon
Impacts operation of the Cilium daemon.
area/metrics
Impacts statistics / metrics gathering, eg via Prometheus.
kind/enhancement
This would improve or streamline existing functionality.
release-note/misc
This PR makes changes that have no direct user impact.
labels
Dec 28, 2022
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
and removed
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
labels
Dec 28, 2022
github-actions
bot
added
the
kind/community-contribution
This was a contribution made by a community member.
label
Dec 28, 2022
christarazi
removed
the
kind/community-contribution
This was a contribution made by a community member.
label
Dec 28, 2022
christarazi
changed the title
pr/christarazi/improve metrics ux
Slightly improve UX around passing Dec 28, 2022
--metrics
christarazi
force-pushed
the
pr/christarazi/improve-metrics-ux
branch
from
January 4, 2023 06:31
a1f1196
to
3d0622b
Compare
/test |
christarazi
force-pushed
the
pr/christarazi/improve-metrics-ux
branch
from
January 4, 2023 19:43
3d0622b
to
ff3e286
Compare
This is useful for pointing out mistakes / typos when configuring metrics. If a user inputs an unknown metric, this warning should help the user realize their mistake. Signed-off-by: Chris Tarazi <chris@isovalent.com>
It wasn't clear that Cilium expects the string passed to --metrics to be separated by a space when multiple metric names are passed. Clarify it in the help msg. Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
force-pushed
the
pr/christarazi/improve-metrics-ux
branch
from
January 4, 2023 19:43
ff3e286
to
fecd427
Compare
/test |
sayboras
approved these changes
Jan 5, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/daemon
Impacts operation of the Cilium daemon.
area/metrics
Impacts statistics / metrics gathering, eg via Prometheus.
kind/enhancement
This would improve or streamline existing functionality.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.