Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing node neigh metric for counting arping requests #22930

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Fix missing node neigh metric for counting arping requests #22930

merged 1 commit into from
Jan 5, 2023

Conversation

christarazi
Copy link
Member

@christarazi christarazi commented Jan 4, 2023 •
edited

The metric was never enabled due to the missing subsystem from the
switch case.

Fixes: 42eb1ed ("node-neigh: add metric to count arping requests")

Signed-off-by: Chris Tarazi chris@isovalent.com

Fixes: #14816
Related: #22888

@christarazi
metrics: Fix missing node neigh metric
a4afdf3 
The metric was never enabled due to the missing subsystem from the
switch case.

Fixes: 42eb1ed ("node-neigh: add metric to count arping requests")

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi added area/daemon Impacts operation of the Cilium daemon. area/metrics Impacts statistics / metrics gathering, eg via Prometheus. kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. labels Jan 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 4, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 4, 2023
@christarazi christarazi added needs-backport/1.10 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch and removed kind/community-contribution This was a contribution made by a community member. labels Jan 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.19 Jan 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.12.6 Jan 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.13 Jan 4, 2023
@christarazi christarazi added affects/v1.11 This issue affects v1.11 branch affects/v1.10 This issue affects v1.10 branch and removed needs-backport/1.10 labels Jan 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.11.13 Jan 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from master in 1.10.19 Jan 4, 2023
@christarazi christarazi marked this pull request as ready for review January 4, 2023 21:29
@christarazi christarazi requested a review from a team as a code owner January 4, 2023 21:29
@christarazi christarazi changed the title metrics: Fix missing node neigh metric Fix missing node neigh metric Jan 4, 2023
@christarazi christarazi changed the title Fix missing node neigh metric Fix missing node neigh metric for counting arping requests Jan 4, 2023
@christarazi
Copy link
Member Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 5, 2023
aditighag
aditighag reviewed Jan 5, 2023
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have arping code in the repo? 😕 /cc @brb Is there a timeline to deprecate/remove the code?

@aditighag aditighag merged commit 6820a56 into cilium:master Jan 5, 2023
@christarazi christarazi deleted the pr/christarazi/fix-missing-node-neigh-metric branch January 5, 2023 17:19
@gentoo-root gentoo-root mentioned this pull request Jan 6, 2023
Merged
@aditighag aditighag mentioned this pull request Jan 9, 2023
Merged
@aditighag aditighag added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jan 9, 2023
@ti-mo ti-mo mentioned this pull request Jan 13, 2023
Closed
This was referenced Jan 19, 2023
Closed
Merged
@joestringer joestringer mentioned this pull request Jan 24, 2023
Merged
@ldelossa ldelossa added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Jan 24, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.12 in 1.12.6 Jan 24, 2023
@michi-covalent michi-covalent mentioned this pull request Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditighag aditighag aditighag left review comments

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
affects/v1.10 This issue affects v1.10 branch affects/v1.11 This issue affects v1.11 branch area/daemon Impacts operation of the Cilium daemon. area/metrics Impacts statistics / metrics gathering, eg via Prometheus. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.12.6
Backport done to v1.12
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@christarazi @sayboras @aditighag @ti-mo @ldelossa