ci-datapath: Fix issue where test were wrongly reported as passing #24813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gandro
added
sig/datapath
gandro
force-pushed
the
pr/gandro/fix-ci-datapath-error-reporting
branch
from
464eb85
to
ccc6263
Compare
|
Before this commit, the ci-datapath workflow would update the PR status for each `setup-and-test` matrix job. That however lead to the PR being marked as green as soon as the first matrix job succeeded, even though later tests might fail. Worse, if an earlier matrix job failed, and a later one succeeded, the latter job masked the failure of the earlier job and marked the PR as green as well. This commit fixes the issue by only updating the commit status once all jobs have run. This technique is taken from #23865 and has been used for the BPF verifier workflow for a while. Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
force-pushed
the
pr/gandro/fix-ci-datapath-error-reporting
branch
2 times, most recently
from
adea8a1
to
4813172
Compare
pchaigno
approved these changes
Apr 11, 2023
pchaigno
added
the
ready-to-merge
|
I think this PR introduced another issue with the workflow status: #24915. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the ci-datapath workflow would update the PR status
for each
setup-and-testmatrix job. That however lead to the PR beingmarked as green as soon as the first matrix job succeeded, even though
later tests might fail.
Worse, if an earlier matrix job failed, and a later one succeeded, the
latter job masked the failure of the earlier job and marked the PR as
green as well.
This commit fixes the issue by only updating the commit status once all
jobs have run. This technique is taken from #23865 and has
been used for the BPF verifier workflow for a while.