New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gateway-api: fixed RequestRedirect picks wrong port with multiple listeners #31361
Conversation
Before: |
/CC @sayboras PTAL. |
/test |
0bf138a
to
d539140
Compare
Fixes: 29099 If RequestRedirect does not specify a port and schem is empty. The port of the listener is used by default. Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
d539140
to
d203f20
Compare
/test |
/ci-ginkgo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably have missed the default port details from upstream spec. Thanks and lgtm.
@sayboras @chaunceyjiang I've attempted to backport this to v1.15, but the unit test is failing and I lack the domain knowledge to fix it. Marking as "backport/author", i.e. asking one of you to backport this to v1.15 yourselves (or removing the "needs backport" label. |
sure, thanks for the ping. I have a few more lined up related to Gateway API backport, will bundle all of them together in on backport PR. |
Fixes: #29099
If RequestRedirect does not specify a port. The port of the listener is used by default.