Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.15 Author Backports 2024-04-04 for Gateway API #31769

Merged
merged 3 commits into from Apr 5, 2024
Merged

v1.15 Author Backports 2024-04-04 for Gateway API #31769

merged 3 commits into from Apr 5, 2024

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Apr 4, 2024 •
edited

@cjvirtucio87 @sayboras
bugfix: hostname config in httproute and gateway
3249f5f 
[ upstream commit a052869 ]

This fixes a bug where the hostname config isn't
respected when set on a Gateway Listener and
on an HTTPRoute's spec.

Fixes: #30685

Signed-off-by: CJ Virtucio <cjv287@gmail.com>
@sayboras sayboras added kind/backports This PR provides functionality previously merged into master. backport/1.15 This PR represents a backport for Cilium 1.15.x of a PR that was merged to main. labels Apr 4, 2024
@sayboras sayboras changed the title v1.15 Backports 2024-04-04 v1.15 Author Backports 2024-04-04 for Gateway API Apr 4, 2024
@chaunceyjiang @sayboras
gateway-api: shorten the length of the value of the svc's label.
dcfe7bd 
[ upstream commit d6fbccf ]

Fixes #31285

When creating a gateway-api with a name exceeding 64 characters, it is impossible to create svc.

This is because the label of svc references the name of gateway-api.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang @sayboras
gateway-api: RequestRedirect picks wrong port with multiple listeners
e546df1 
[ upstream commit 74119be ]

Fixes: 29099

If RequestRedirect does not specify a port and schem is empty. The port of the listener is used by default.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the pr/v1.15-backport-2024-04-04-08-57 branch from 82565ed to e546df1 Compare April 4, 2024 10:52
@sayboras
Copy link
Member Author

sayboras commented Apr 4, 2024

/test

@sayboras
Copy link
Member Author

sayboras commented Apr 4, 2024

/ci-gateway-api

@sayboras
Copy link
Member Author

sayboras commented Apr 4, 2024

/test-backport-1.15

@sayboras sayboras marked this pull request as ready for review April 4, 2024 11:06
@sayboras sayboras requested a review from a team as a code owner April 4, 2024 11:06
julianwiedmann
julianwiedmann approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀. Do we want to wait for more review, or merge?

@sayboras sayboras merged commit 77e7331 into v1.15 Apr 5, 2024
226 of 227 checks passed
@sayboras sayboras deleted the pr/v1.15-backport-2024-04-04-08-57 branch April 5, 2024 09:24
@asauber asauber mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianwiedmann julianwiedmann julianwiedmann approved these changes

@chaunceyjiang chaunceyjiang Awaiting requested review from chaunceyjiang

Assignees
No one assigned
Labels
backport/1.15 This PR represents a backport for Cilium 1.15.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sayboras @julianwiedmann @cjvirtucio87 @chaunceyjiang