Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway-api: fixed RequestRedirect picks wrong port with multiple listeners #31361

Merged
merged 1 commit into from Mar 14, 2024
Merged

gateway-api: fixed RequestRedirect picks wrong port with multiple listeners #31361

merged 1 commit into from Mar 14, 2024
+262 −3

Conversation

chaunceyjiang
Copy link
Member

@chaunceyjiang chaunceyjiang commented Mar 13, 2024 •
edited

Fixes: #29099

If RequestRedirect does not specify a port. The port of the listener is used by default.

gateway-api: fixed RequestRedirect picks wrong port with multiple listeners

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 13, 2024
@chaunceyjiang
Copy link
Member Author

Before:
#29099 (comment)

After:
image

@chaunceyjiang
Copy link
Member Author

/CC @sayboras PTAL.

@chaunceyjiang
Copy link
Member Author

/test

@sayboras sayboras self-requested a review March 13, 2024 04:54
@sayboras sayboras added release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Mar 13, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 13, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.15.2 Mar 13, 2024
@chaunceyjiang
gateway-api: RequestRedirect picks wrong port with multiple listeners
d203f20 
Fixes: 29099

If RequestRedirect does not specify a port and schem is empty. The port of the listener is used by default.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
Copy link
Member Author

/test

@jrajahalme jrajahalme removed this from Needs backport from main in 1.15.2 Mar 13, 2024
@chaunceyjiang chaunceyjiang marked this pull request as ready for review March 14, 2024 02:00
@chaunceyjiang chaunceyjiang requested a review from a team as a code owner March 14, 2024 02:00
@chaunceyjiang
Copy link
Member Author

/ci-ginkgo

sayboras
sayboras approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably have missed the default port details from upstream spec. Thanks and lgtm.

@sayboras sayboras enabled auto-merge March 14, 2024 04:10
@sayboras sayboras added this pull request to the merge queue Mar 14, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 14, 2024
Merged via the queue into cilium:main with commit 74119be Mar 14, 2024
62 checks passed
@gandro
Copy link
Member

gandro commented Mar 19, 2024

@sayboras @chaunceyjiang I've attempted to backport this to v1.15, but the unit test is failing and I lack the domain knowledge to fix it. Marking as "backport/author", i.e. asking one of you to backport this to v1.15 yourselves (or removing the "needs backport" label.

@sayboras
Copy link
Member

sure, thanks for the ping. I have a few more lined up related to Gateway API backport, will bundle all of them together in on backport PR.

@sayboras sayboras added the backport/author The backport will be carried out by the author of the PR. label Mar 19, 2024
@chaunceyjiang chaunceyjiang deleted the rr_pick_wrong_port branch March 19, 2024 10:41
@gandro gandro mentioned this pull request Mar 19, 2024
Merged
21 tasks
@sayboras sayboras mentioned this pull request Apr 4, 2024
Merged
3 tasks
@sayboras sayboras added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Apr 4, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Apr 5, 2024
@asauber asauber mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
backport/author The backport will be carried out by the author of the PR. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gateway API RequestRedirect picks wrong port with multiple listeners
3 participants
@chaunceyjiang @gandro @sayboras