Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

policy: clean a duplicated code #10016

Merged
merged 1 commit into from
Feb 5, 2020
Merged

policy: clean a duplicated code #10016

merged 1 commit into from
Feb 5, 2020

Conversation

zhiyuan0x
Copy link
Contributor

@zhiyuan0x zhiyuan0x commented Feb 1, 2020 •
edited by tgraf
Loading

This change is Reviewable

@zhiyuan0x
policy: clean a duplicated code
3dbb3e7 
Signed-off-by: Zhiyuan Hou <zhiyuan2048@linux.alibaba.com>
@zhiyuan0x zhiyuan0x requested a review from a team February 1, 2020 08:37
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 44.766% when pulling 3dbb3e7 on zhiyuan0x:clean into 394e724 on cilium:master.

aanm
aanm approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@aanm aanm added kind/cleanup This includes no functional changes. pending-review labels Feb 3, 2020
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

1 similar comment
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@aanm
Copy link
Member

aanm commented Feb 3, 2020

test-me-please

@aanm aanm added the release-note/misc This PR makes changes that have no direct user impact. label Feb 3, 2020
@aanm
Copy link
Member

aanm commented Feb 3, 2020

test-me-please

1 similar comment
@joestringer
Copy link
Member

test-me-please

@aanm
Copy link
Member

aanm commented Feb 4, 2020

test-me-please

@aanm aanm added this to the 1.7 milestone Feb 4, 2020
@aanm aanm added needs-backport/1.7 dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. and removed needs-backport/1.7 labels Feb 4, 2020
@aanm
Copy link
Member

aanm commented Feb 4, 2020

test-me-please

@aanm aanm removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Feb 4, 2020
@borkmann borkmann merged commit 909021c into cilium:master Feb 5, 2020
@borkmann borkmann mentioned this pull request Feb 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@aanm aanm aanm approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@zhiyuan0x @coveralls @aanm @joestringer @borkmann