daemon: Add KubeProxyReplacement to cilium status cmd #10059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
pending-review
area/daemon
|
test-me-please |
aanm
approved these changes
Feb 5, 2020
brb
force-pushed
the
pr/brb/kubeproxy-free-status
branch
from
456a4ad
to
206d045
Compare
|
test-me-please |
brb
force-pushed
the
pr/brb/kubeproxy-free-status
branch
from
206d045
to
fea00f7
Compare
It's going to be used when reporting kube-proxy replacement state in "cilium status" output. Signed-off-by: Martynas Pumputis <m@lambda.lt>
This commit adds kube-proxy-replacement configuration to "cilium status"
cmd output, so that users could better detect which kube-proxy replacement
features are enabled.
The example of such output:
$ cilium status
KVStore: Ok Disabled
Kubernetes: Ok 1.17 (v1.17.2) [linux/amd64]
Kubernetes APIs: ["CustomResourceDefinition", "cilium/v2::CiliumClusterwideNetworkPolicy", "cilium/v2::CiliumEndpoint", "cilium/v2::CiliumNetworkPolicy", "cilium/v2::CiliumNode", "core/v1::Endpoint", "core/v1::Namespace", "core/v1::Pods", "core/v1::Service", "networking.k8s.io/v1::NetworkPolicy"]
KubeProxyReplacement: Strict [NodePort, ExternalIPs, HostReachableServicesTCP, HostReachableServicesUDP]
Cilium: Ok OK
NodeMonitor: Disabled
Cilium health daemon: Ok
IPAM: IPv4: 4/65535 allocated from 10.1.0.0/16,
Controller Status: 17/17 healthy
Proxy Status: OK, ip 10.1.28.236, port-range 10000-20000
Cluster health: 0/1 reachable (2020-02-05T14:02:54+01:00)
Name IP Reachable Endpoints reachable
ceuse (localhost) 10.5.57.1 true false
Signed-off-by: Martynas Pumputis <m@lambda.lt>
This commit:
- Disables option.Config.EnableExternalIP if NodePort is disabled
- Disables option.EnableHostServices{TCP,UDP} if host-lb is disabled
Otherwise, "cilium status" when --kube-proxy-replacement=partial will
misleadingly report that ExternalIP and HostServices{TCP,UDP} are
enabled even if NodePort and host-lb is disabled.
Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
test-me-please |
|
provisioning error |
|
test-me-please |
|
Btw, one more thought. We should also dump the used node-port port-range and whether we use snat or dsr for node-port services. Can also be follow-up, but we should do this as well for 1.7. |
|
Perhaps makes sense to slightly adapt the output for above case, for example: |
borkmann
moved this from Done
to In progress (1.7)
in 1.9 kube-proxy removal & general dp optimization
Makes sense, will do it as a follow-up. |
|
test-me-please |
borkmann
moved this from In progress (1.7)
to Done
in 1.9 kube-proxy removal & general dp optimization
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.0-rc4
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.7
in 1.7.0-rc4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds kube-proxy replacement configuration to the
cilium statuscmd. E.g.:Reviewable per commit.
This change is