Makefile: move cscope.files generation to its own target #10182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 6c66fe9 ("Makefile: Fix duplicates in cscope output") added cscope.files as a dependency to the "tags" target. However, this is the very target supposed to be used to build cscope.files in the first place, so running "make tags" for the first time (when cscope.files is not present) fails. Let's keep cscope.files as a dependency for "tags", but move the generation of that file to its own target. Also silence the "ctags" command when creating tags. Fixes: 6c66fe9 ("Makefile: Fix duplicates in cscope output") Signed-off-by: Quentin Monnet <quentin@isovalent.com>
vadorovsky
approved these changes
Feb 13, 2020
joestringer
approved these changes
Feb 13, 2020
joestringer
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 6c66fe9 ("Makefile: Fix duplicates in cscope output") added cscope.files as a dependency to the "tags" target. However, this is the very target supposed to be used to build cscope.files in the first place, so running "make tags" for the first time (when cscope.files is not present) fails.
Let's keep cscope.files as a dependency for "tags", but move the generation of that file to its own target.
Also silence the "ctags" command when creating tags.
This change is