Make resources in agent and operator helm chart configurable #10296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Bischoff <maximilian.bischoff@inovex.de>
maxbischoff
commented
Feb 21, 2020
| resources: {} | ||
|
|
||
| # Specifies the resources for the clean-cilium-state init container | ||
| initResources: |
There was a problem hiding this comment.
I am not particularly fond of this naming but also could not come up with anything better. If you have a suggestion I would happily change it.
|
test-me-please |
aanm
requested changes
Feb 24, 2020
|
Release note label not set, please set the appropriate release note. |
aanm
added
the
release-note/misc
aanm
added
release-note/minor
aanm
approved these changes
Feb 25, 2020
tklauser
approved these changes
Feb 25, 2020
|
test-me-please |
joestringer
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Enables users of the helm chart to provide resource requests and limits to the containers of the agent and operator deployment/daemonset. Also provides default requests for the agent's initContainer.
This change is