Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty resource block in generated quick-install.yaml #10350

Closed
aanm opened this issue Feb 26, 2020 · 2 comments · Fixed by #10363
Closed

Empty resource block in generated quick-install.yaml #10350

aanm opened this issue Feb 26, 2020 · 2 comments · Fixed by #10363
Labels
kind/bug This is a bug in the Cilium logic.

Comments

@aanm
Copy link
Member

aanm commented Feb 26, 2020

It seems this was introduced by #10296 . @maxbischoff can you take a look?

The quick-install.yaml is generated by running make -C install/kubernetes clean all

@maxbischoff
Copy link
Contributor

It was definitely introduced by my PR. I did not provide resource requests for agent and operator there on purpose as those will probably depend on cluster & node size.
Maybe I am missing something, but in my opinion an empty resource block should be equivalent to the state before my merge request, is there a problem with it? Or is it just the missing update on the quick-install.yaml? I can add a PR that adds the new quick-install.

I can also add a PR that changes the chart to not render the resources if they are empty, though I do not see the point to be honest.

@aanm
Copy link
Member Author

aanm commented Feb 27, 2020

I can also add a PR that changes the chart to not render the resources if they are empty, though I do not see the point to be honest.

@maxbischoff yes this was why I created the GH issue. Leaving the "resources" empty might give the impression to users that we don't want to have any resources being applied into Cilium.

aanm pushed a commit that referenced this issue Mar 4, 2020
Fixes: #10350

Signed-off-by: Maximilian Bischoff <maximilian.bischoff@inovex.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug This is a bug in the Cilium logic.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants