Add ability to use cilium config map in cilium-operator automatically

[aanm]

Please read commit by commit. I tried to make gradual changes but it was a little difficult with the flags.

Cilium Operator can now use the flags specified `cilium-config` k8s configuration map

---

This change is 

[aanm]

test-me-please

[coveralls]

Coverage increased (+0.09%) to 45.549% when pulling aa129d6 on pr/clean-operator-flags into c9de62b on master.

[ungureanuvladvictor]

Reviewed 2 of 2 files at r1, 11 of 11 files at r2, 6 of 6 files at r3, 3 of 3 files at r4, 6 of 6 files at r5.
Reviewable status: complete! all files reviewed, 7 unresolved discussions (waiting on @aanm)

---

install/kubernetes/quick-install.yaml, line 121 at r5 (raw file):

  masquerade: "true"
  enable-xt-socket-fallback: "true"

Was this missing from somewhere?

---

install/kubernetes/quick-install.yaml, line 411 at r5 (raw file):

              - /cni-uninstall.sh
        resources:
          {}

Do you think it's valuable to leave this here but with empty resources block?

---

install/kubernetes/cilium/charts/config/templates/configmap.yaml, line 66 at r5 (raw file):

  # which the Cilium Operator will have their metrics exposed.
  # NOTE that this will open the port on the nodes where Cilium operator pods
  # are scheduled.

where Cilium operator pod is scheduled since we cannot run the operator in HA mode?

---

operator/flags.go, line 82 at r2 (raw file):

	option.BindEnv(option.CNPNodeStatusGCInterval)

	flags.Duration(option.CNPStatusUpdateInterval, 1*time.Second, "interval between CNP status updates sent to the k8s-apiserver per-CNP")

s/interval/Interval just to keep it consistent related to capitalization of other description of options.

---

operator/flags.go, line 154 at r2 (raw file):

	option.BindEnv(option.Version)

	// TODO: Urgent fix

Fix related to ?

---

operator/main.go, line 136 at r2 (raw file):

		option.Config.K8sAPIServer,
		option.Config.K8sKubeConfigPath,
		float32(option.Config.K8sClientQPSLimit),

option.Config.K8sClientQPSLimit is of type float32 already, don't think you need the cast

---

operator/metrics.go, line 43 at r3 (raw file):

func getPrometheusServerAddr() string {
	if option.Config.OperatorPrometheusServeAddr == "" {
		return metricsAddress

given we'll use metricsAddress just here is it worth keeping in operator/main.go?

[aanm]

Reviewed 2 of 2 files at r1, 11 of 11 files at r2, 6 of 6 files at r3, 3 of 3 files at r4, 6 of 6 files at r5.
Reviewable status: complete! all files reviewed, 7 unresolved discussions (waiting on @aanm)

install/kubernetes/quick-install.yaml, line 121 at r5 (raw file):

  masquerade: "true"
  enable-xt-socket-fallback: "true"

Was this missing from somewhere?

This file is auto generated it was probably some older PR that merged changes without generating the file

install/kubernetes/quick-install.yaml, line 411 at r5 (raw file):

              - /cni-uninstall.sh
        resources:
          {}

Do you think it's valuable to leave this here but with empty resources block?

This file is auto generated it was probably some older PR that merged changes without generating the file. But to answer your question, this does seem suspicious. I've open #10350 to track this.

install/kubernetes/cilium/charts/config/templates/configmap.yaml, line 66 at r5 (raw file):

  # which the Cilium Operator will have their metrics exposed.
  # NOTE that this will open the port on the nodes where Cilium operator pods
  # are scheduled.

where Cilium operator pod is scheduled since we cannot run the operator in HA mode?

👍

operator/flags.go, line 82 at r2 (raw file):

	option.BindEnv(option.CNPNodeStatusGCInterval)

	flags.Duration(option.CNPStatusUpdateInterval, 1*time.Second, "interval between CNP status updates sent to the k8s-apiserver per-CNP")

s/interval/Interval just to keep it consistent related to capitalization of other description of options.

👍

operator/flags.go, line 154 at r2 (raw file):

	option.BindEnv(option.Version)

	// TODO: Urgent fix

Fix related to ?

This was intended for me to not forget about it. I'll fix it once the PR is merged since it requires backport to 1.7. It's basically because the operator is opening that port on host network level to serve health requests to kubelet.

operator/main.go, line 136 at r2 (raw file):

		option.Config.K8sAPIServer,
		option.Config.K8sKubeConfigPath,
		float32(option.Config.K8sClientQPSLimit),

option.Config.K8sClientQPSLimit is of type float32 already, don't think you need the cast

it's of type float64. Unfortunately, viper does not have viper.GetFloat32

operator/metrics.go, line 43 at r3 (raw file):

func getPrometheusServerAddr() string {
	if option.Config.OperatorPrometheusServeAddr == "" {
		return metricsAddress

given we'll use metricsAddress just here is it worth keeping in operator/main.go?

good point, will do

[aanm]

test-me-please

[joestringer]

Docs changes LGTM. I didn't look at the other changes in detail.

[joestringer]

test-docs-please

[ungureanuvladvictor]

Reviewed 20 of 20 files at r7.
Reviewable status: complete! all files reviewed, all discussions resolved