New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Add hubble section #10358
helm: Add hubble section #10358
Conversation
Release note label not set, please set the appropriate release note. |
7090338
to
1ee747a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see where HUBBLE_DEFAULT_SOCKET_PATH
nor HUBBLE_GROUP_NAME
are used in the cilium's code base so I assume this is waiting for #10238 to be merged first?
right. these are env variables in hubble that will be available once #10238 is merged, although this pr is not really blocked on it since it doesn't add any hubble-related settings by default unless you specify them in helm command. |
1ee747a
to
56abea7
Compare
The observe subcommand executes Hubble's observe command. We are still trying to figure out how to distribute Hubble's CLI. This is a short term workaround so that people can use it to interact with Hubble in the meantime. Ref #9925 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Add hubble section to values.yaml, and add new Hubble-related fields to the configmap. The configmap has these new hubble-related fields: - hubble-listen-addresses List of addresses for Hubble to listen to. Disabled if empty. - hubble-flow-buffer-size Number of recent flows for Hubble to cache. Defaults to 4096. - hubble-event-queue-size Buffer size of the events channel. Defaults to 128. - hubble-metrics-server Address for the metric server to listen to. Disabled if empty. - hubble-metrics List of metrics to collect. This PR also adds 2 environment variables if Hubble is enabled: - HUBBLE_GROUP_NAME Group for Hubble's unix domain sockets. Hardcoded to be `cilium`. - HUBBLE_DEFAULT_SOCKET_PATH Default Hubble gRPC endpoint for observe/status commands. This is set to the first address in hubble-listen-addresses. Here is a sample helm command to configure Hubble-related settings: helm template cilium \ --set global.hubble.listenAddresses="{unix:///var/run/cilium/hubble.sock,unix:///var/run/cilium/hubble.sock2}" \ --set global.hubble.eventQueueSize=1234 \ --set global.hubble.flowBufferSize=5678 \ --set global.hubble.metricsServer=":7071" \ --set global.hubble.metrics="{dns:query;ignoreAAAA,drop,tcp,flow,port-distribution,icmp,http}" Ref #9925 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
56abea7
to
fd9f75c
Compare
test-me-please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment regarding event queue size. I'm fine if we fix this in a follow-up PR though.
2 commits:
cilium observe
subcommand to get flows from hubble.This change is