Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update github.com/go-openapi/loads #10364

Merged
merged 1 commit into from Feb 27, 2020
Merged

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Feb 27, 2020

This will pull in memory usage improvements from go-openapi/analysis#54

Updates #10056

Signed-off-by: Tobias Klauser tklauser@distanz.ch


This change is Reviewable

This will pull in memory usage improvements from go-openapi/analysis#54

Updates #10056

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Feb 27, 2020
@tklauser tklauser requested review from a team as code owners February 27, 2020 17:31
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Feb 27, 2020
@tklauser
Copy link
Member Author

test-me-please

Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we pin this version somewhere by importing the dependency directly?

@tklauser
Copy link
Member Author

Shouldn't we pin this version somewhere by importing the dependency directly?

I tried that, but since the version pinned in github.com/go-openapi/loads is currently the latest version github.com/go-openapi/analysis (due to go-openapi/loads#26) it didn't make any difference.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 45.532% when pulling a4f6215 on pr/tklauser/bump-openapi-loads into 0c67ebf on master.

@aanm
Copy link
Member

aanm commented Feb 27, 2020

Shouldn't we pin this version somewhere by importing the dependency directly?

I tried that, but since the version pinned in github.com/go-openapi/loads is currently the latest version github.com/go-openapi/analysis (due to go-openapi/loads#26) it didn't make any difference.

great, perfect!

@aanm aanm merged commit 1885bb4 into master Feb 27, 2020
1.8.0 automation moved this from In progress to Merged Feb 27, 2020
@aanm aanm deleted the pr/tklauser/bump-openapi-loads branch February 27, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

3 participants