Pass pointer to schema to (*Spec).analyzeSchema instead of copying #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to reduce the memory consumption during loads.Analyzed significantly. before: ``` 2076.76kB 21.23% 21.23% 2076.76kB 21.23% github.com/go-openapi/analysis.(*Spec).reset 1024.06kB 10.47% 57.11% 1024.06kB 10.47% github.com/go-openapi/analysis.(*Spec).analyzeSchema ``` after (analyzeSchema doesn't even show up in the memory profile anymore): ``` 1034.66kB 15.31% 15.31% 1034.66kB 15.31% github.com/go-openapi/analysis.(*Spec).reset ``` Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 92.23% 92.27% +0.03%
==========================================
Files 7 7
Lines 1817 1825 +8
==========================================
+ Hits 1676 1684 +8
Misses 90 90
Partials 51 51 Continue to review full report at Codecov.
|
10 tasks
|
We are copying so that modifications to elements in the analyzed schema don't show up in the spec. |
casualjim
approved these changes
Feb 27, 2020
tklauser
added a commit
to cilium/cilium
that referenced
this pull request
Feb 27, 2020
This will pull in memory usage improvements from go-openapi/analysis#54 Updates #10056 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
aanm
pushed a commit
to cilium/cilium
that referenced
this pull request
Feb 27, 2020
This will pull in memory usage improvements from go-openapi/analysis#54 Updates #10056 Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to reduce the memory consumption during loads.Analyzed
significantly.
before:
after (analyzeSchema doesn't even show up in the memory profile anymore):
Signed-off-by: Tobias Klauser tklauser@distanz.ch