Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hubble: Change the default event queue size #10488

Merged
merged 1 commit into from Mar 11, 2020
Merged

Conversation

michi-covalent
Copy link
Contributor

@michi-covalent michi-covalent commented Mar 5, 2020

Use the logic to calculate the default monitor queue size to get the
default event queue size for Hubble instead of hardcoding the default
to be 128.

Ref cilium/hubble#161
Ref https://github.com/cilium/cilium/pull/10358/files/fd9f75ca92a8cd9cc0446b5dea13f4f9894cd90b#r388162620

Signed-off-by: Michi Mutsuzaki michi@isovalent.com


This change is Reviewable

@michi-covalent michi-covalent requested a review from a team March 5, 2020 19:23
@michi-covalent michi-covalent requested a review from a team as a code owner March 5, 2020 19:23
@michi-covalent michi-covalent requested a review from a team March 5, 2020 19:23
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@coveralls
Copy link

coveralls commented Mar 5, 2020

Coverage Status

Coverage decreased (-0.009%) to 45.617% when pulling e93a211 on pr/michi/monitorqueue into 99e6bc8 on master.

Use the logic to calculate the default monitor queue size to get the
default event queue size for Hubble instead of hardcoding the default
to be 128.

Ref cilium/hubble#161
Ref https://github.com/cilium/cilium/pull/10358/files/fd9f75ca92a8cd9cc0446b5dea13f4f9894cd90b#r388162620

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent changed the title hubble: Remove --hubble-event-queue-size option hubble: Change the default event queue size Mar 5, 2020
@michi-covalent
Copy link
Contributor Author

test-me-please

@michi-covalent
Copy link
Contributor Author

test-me-please

@tgraf tgraf merged commit 711b37e into master Mar 11, 2020
1.8.0 automation moved this from In progress to Merged Mar 11, 2020
@tgraf tgraf deleted the pr/michi/monitorqueue branch March 11, 2020 18:06
@rolinh rolinh added the sig/hubble Impacts hubble server or relay label Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

5 participants