New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hubble: Change the default event queue size #10488
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release note label not set, please set the appropriate release note. |
michi-covalent
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
Mar 5, 2020
Use the logic to calculate the default monitor queue size to get the default event queue size for Hubble instead of hardcoding the default to be 128. Ref cilium/hubble#161 Ref https://github.com/cilium/cilium/pull/10358/files/fd9f75ca92a8cd9cc0446b5dea13f4f9894cd90b#r388162620 Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/monitorqueue
branch
from
March 5, 2020 21:45
f32b85f
to
e93a211
Compare
michi-covalent
changed the title
hubble: Remove --hubble-event-queue-size option
hubble: Change the default event queue size
Mar 5, 2020
test-me-please |
gandro
approved these changes
Mar 5, 2020
test-me-please |
rolinh
approved these changes
Mar 6, 2020
tgraf
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release-note/misc
This PR makes changes that have no direct user impact.
sig/hubble
Impacts hubble server or relay
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the logic to calculate the default monitor queue size to get the
default event queue size for Hubble instead of hardcoding the default
to be 128.
Ref cilium/hubble#161
Ref https://github.com/cilium/cilium/pull/10358/files/fd9f75ca92a8cd9cc0446b5dea13f4f9894cd90b#r388162620
Signed-off-by: Michi Mutsuzaki michi@isovalent.com
This change is