-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile:Add arm64 support for building images #10618
Conversation
Release note label not set, please set the appropriate release note. |
curl -SsL https://github.com/cilium/bpf-map/releases/download/v1.0/bpf-map -o bpf-map && \ | ||
chmod +x bpf-map && \ | ||
strip bpf-map && \ | ||
# | ||
# cni/loopback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @borkmann already removed this in master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the master branch again and the bpf-map related code still exists. “removed” mean that bpf-map is no longer required to be installed in Dockerfile.runtime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is still in progress as it was blocked by another one to be merged first: #10542
ba1583e
to
c7bc6e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase but looks generally okay to me.
Add arm64 support for cilium-runtime and cilium-builder Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
c7bc6e0
to
f694009
Compare
test-me-please |
test-with-kernel |
This PR is blocked until some changes are done by @borkmann upstream. |
@aanm @borkmann I think that the upstream Linux changes can be done in parallel, do we need to block Docker image building on that? Also I think we still need to figure out how we can build & distribute builder images (we can distribute through quay.io / dockerhub if we push platform-dependent images, but not sure at this stage how to build them). But I believe that this workflow can also be worked on independent of this PR. |
test-me-please |
Add arm64 support for cilium-runtime and cilium-builder
Signed-off-by: Jianlin Lv Jianlin.Lv@arm.com
Related: #9898
This change is