Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile:Add arm64 support for building images #10618

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

Jianlin-lv
Copy link
Contributor

@Jianlin-lv Jianlin-lv commented Mar 18, 2020

Add arm64 support for cilium-runtime and cilium-builder

Signed-off-by: Jianlin Lv Jianlin.Lv@arm.com

Related: #9898


This change is Reviewable

@Jianlin-lv Jianlin-lv requested review from aanm, ianvernon and a team as code owners March 18, 2020 08:52
@maintainer-s-little-helper
Copy link

Release note label not set, please set the appropriate release note.

@coveralls
Copy link

coveralls commented Mar 18, 2020

Coverage Status

Coverage decreased (-0.03%) to 45.896% when pulling f694009 on Jianlin-lv:pr-support-arm64 into 72fe87a on cilium:master.

curl -SsL https://github.com/cilium/bpf-map/releases/download/v1.0/bpf-map -o bpf-map && \
chmod +x bpf-map && \
strip bpf-map && \
#
# cni/loopback
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @borkmann already removed this in master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the master branch again and the bpf-map related code still exists. “removed” mean that bpf-map is no longer required to be installed in Dockerfile.runtime?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is still in progress as it was blocked by another one to be merged first: #10542

@aanm aanm added pending-review release-note/misc This PR makes changes that have no direct user impact. labels Mar 18, 2020
@joestringer joestringer added the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Apr 6, 2020
Copy link
Member

@borkmann borkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase but looks generally okay to me.

Add arm64 support for cilium-runtime and  cilium-builder

Signed-off-by: Jianlin Lv <Jianlin.Lv@arm.com>
@tklauser tklauser removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Apr 7, 2020
@tklauser
Copy link
Member

tklauser commented Apr 7, 2020

test-me-please

@tklauser
Copy link
Member

tklauser commented Apr 8, 2020

test-with-kernel

@aanm
Copy link
Member

aanm commented Apr 9, 2020

This PR is blocked until some changes are done by @borkmann upstream.

@aanm aanm added the dont-merge/waiting-for-upstream Only merge once upstream library or kernel features have landed label Apr 9, 2020
@joestringer
Copy link
Member

@aanm @borkmann I think that the upstream Linux changes can be done in parallel, do we need to block Docker image building on that?

Also I think we still need to figure out how we can build & distribute builder images (we can distribute through quay.io / dockerhub if we push platform-dependent images, but not sure at this stage how to build them). But I believe that this workflow can also be worked on independent of this PR.

@aanm aanm removed the dont-merge/waiting-for-upstream Only merge once upstream library or kernel features have landed label Apr 14, 2020
@aanm
Copy link
Member

aanm commented Apr 14, 2020

test-me-please

@aanm aanm merged commit 69ccfda into cilium:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants