loader: Fixes for map creation from daemon #10728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
pending-review
sig/loader
pchaigno
force-pushed
the
pr/pchaigno/followups-pr-open-maps
branch
from
df47761
to
be5f095
Compare
brb
requested changes
Mar 27, 2020
The policy call map was renamed, but the list of symbols to skip in the
ELF wasn't updated, resulting in the following warning:
2020-03-25T23:08:21.073661843Z level=warning msg="Skipping symbol substitution" subsys=elf symbol=cilium_call_policy
Fixes: 5d6b669 ("maps/policymap: Rename policy call map to clarify intent")
Signed-off-by: Paul Chaignon <paul@cilium.io>
Commit 8fd7415 introduces a Go definition of the NodePort neighbor maps, to enable their creation during the daemon's initialization. The value structure is however missing some padding to match its C counterpart, resulting in the following warnings: 2020-03-25T23:07:55.245972761Z level=warning msg="Value-size mismatch for BPF map" file-path=/sys/fs/bpf/tc/globals/cilium_nodeport_neigh4 new=6 old=8 subsys=bpf 2020-03-25T23:07:55.245975572Z level=warning msg="Removing map to allow for property upgrade (expect map data loss)" file-path=/sys/fs/bpf/tc/globals/cilium_nodeport_neigh4 subsys=bpf 2020-03-25T23:07:55.256431723Z level=debug msg="Registered BPF map" path=/sys/fs/bpf/tc/globals/cilium_nodeport_neigh4 subsys=bpf 2020-03-25T23:07:55.256461108Z level=debug msg="Unregistered BPF map" path=/sys/fs/bpf/tc/globals/cilium_nodeport_neigh4 subsys=bpf Fixes: 8fd7415 ("maps/neighborsmap, daemon: Create map from daemon") Signed-off-by: Paul Chaignon <paul@cilium.io>
Three new maps were added to pkg/maps/ in #10626. The corresponding checks in alignchecker are however missing. This commit adds them. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
pr/pchaigno/followups-pr-open-maps
branch
from
be5f095
to
d2f3fcc
Compare
|
test-me-please |
This was referenced Mar 27, 2020
brb
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a few follow-up fixes for #10626. Please see commit messages.