Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loader: Fixes for map creation from daemon #10728

Merged
merged 3 commits into from Mar 27, 2020
Merged

loader: Fixes for map creation from daemon #10728

merged 3 commits into from Mar 27, 2020

Commits on Mar 27, 2020

  1. loader: Ignore cilium_call_policy symbol in ELF 

    The policy call map was renamed, but the list of symbols to skip in the
ELF wasn't updated, resulting in the following warning:

    2020-03-25T23:08:21.073661843Z level=warning msg="Skipping symbol substitution" subsys=elf symbol=cilium_call_policy

Fixes: 5d6b669 ("maps/policymap: Rename policy call map to clarify intent")
Signed-off-by: Paul Chaignon <paul@cilium.io>
    @pchaigno
    pchaigno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    2d0d6b6 View commit details
    Browse the repository at this point in the history

  2. pkg/neighborsmap: Missing padding for map values 

    Commit 8fd7415 introduces a Go definition of the NodePort neighbor maps,
to enable their creation during the daemon's initialization. The value
structure is however missing some padding to match its C counterpart,
resulting in the following warnings:

    2020-03-25T23:07:55.245972761Z level=warning msg="Value-size mismatch for BPF map" file-path=/sys/fs/bpf/tc/globals/cilium_nodeport_neigh4 new=6 old=8 subsys=bpf
    2020-03-25T23:07:55.245975572Z level=warning msg="Removing map to allow for property upgrade (expect map data loss)" file-path=/sys/fs/bpf/tc/globals/cilium_nodeport_neigh4 subsys=bpf
    2020-03-25T23:07:55.256431723Z level=debug msg="Registered BPF map" path=/sys/fs/bpf/tc/globals/cilium_nodeport_neigh4 subsys=bpf
    2020-03-25T23:07:55.256461108Z level=debug msg="Unregistered BPF map" path=/sys/fs/bpf/tc/globals/cilium_nodeport_neigh4 subsys=bpf

Fixes: 8fd7415 ("maps/neighborsmap, daemon: Create map from daemon")
Signed-off-by: Paul Chaignon <paul@cilium.io>
    @pchaigno
    pchaigno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    70e74ef View commit details
    Browse the repository at this point in the history

  3. alignchecker: check eventsmap, neighborsmap, and signalmap 

    Three new maps were added to pkg/maps/ in #10626. The corresponding
checks in alignchecker are however missing. This commit adds them.

Signed-off-by: Paul Chaignon <paul@cilium.io>
    @pchaigno
    pchaigno committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    d2f3fcc View commit details
    Browse the repository at this point in the history