Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identity: Factor out model handling #10895

Closed
wants to merge 1 commit into from
Closed

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Apr 8, 2020

The models dependency blows up the dependency chain of pkg/identity
which is otherwise representing a basic type. Move it into a sub
package.

@tgraf tgraf added the release-note/misc This PR makes changes that have no direct user impact. label Apr 8, 2020
@tgraf tgraf requested a review from a team April 8, 2020 14:30
@tgraf tgraf requested review from a team as code owners April 8, 2020 14:30
@tgraf tgraf requested a review from a team April 8, 2020 14:30
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 8, 2020
@coveralls
Copy link

coveralls commented Apr 8, 2020

Coverage Status

Coverage decreased (-0.04%) to 46.944% when pulling 2c3fe01 on pr/tgraf/split-identity-pkg into 450c79c on master.

The models dependency blows up the dependency chain of pkg/identity
which is otherwise representing a basic type. Move it into a sub
package.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf tgraf force-pushed the pr/tgraf/split-identity-pkg branch from 612aefa to 2c3fe01 Compare April 8, 2020 16:41
@tgraf
Copy link
Member Author

tgraf commented Apr 9, 2020

Closing in favor of #10909

@tgraf tgraf closed this Apr 9, 2020
@tgraf tgraf deleted the pr/tgraf/split-identity-pkg branch April 9, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants