Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split various packages to reduce dependency chain #10909

Merged
merged 3 commits into from Apr 9, 2020
Merged

Split various packages to reduce dependency chain #10909

merged 3 commits into from Apr 9, 2020

Conversation

tgraf
Copy link
Member

@tgraf tgraf commented Apr 9, 2020

No description provided.

@tgraf tgraf added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Apr 9, 2020
@tgraf tgraf requested a review from a team April 9, 2020 08:55
@tgraf tgraf requested review from a team as code owners April 9, 2020 08:55
@tgraf tgraf requested review from a team April 9, 2020 08:55
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 9, 2020
This was referenced Apr 9, 2020
Closed
Closed
Closed
@coveralls
Copy link

coveralls commented Apr 9, 2020 •
edited

Coverage Status

Coverage increased (+0.007%) to 46.705% when pulling 3a3f70f on pr/tgraf/pkg-cleanup into f5425fe on master.

@tgraf
labels: Move label filtering into pkg/labelsfilter
1476446 
The labels filter has non-trivial dependencies and is not directly
related to the base Labels type.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
identity: Factor out model handling
3c13354 
The models dependency blows up the dependency chain of pkg/identity
which is otherwise representing a basic type. Move it into a sub
package.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
endpoint: Move id allocation out of pkg/endpoint/id
3a3f70f 
All users of pkg/endpoint/id except for one are using the package to use
helpers around endpoint IDs. The ID allocation pulls in additional
dependencies, split them apart and move the id allocation into
pkg/endpointmanager where it is used.

Signed-off-by: Thomas Graf <thomas@cilium.io>
@tgraf
Copy link
Member Author

tgraf commented Apr 9, 2020 •
edited

test-me-please

// tests-with-kernel failed

@tgraf
Copy link
Member Author

tgraf commented Apr 9, 2020

test-with-kernel

@tgraf tgraf merged commit f136c2a into master Apr 9, 2020
1.8.0 automation moved this from In progress to Merged Apr 9, 2020
@tgraf tgraf deleted the pr/tgraf/pkg-cleanup branch April 9, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tgraf @coveralls @gandro @michi-covalent