Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename hubble-proxy to hubble-relay #11122

Merged
merged 1 commit into from Apr 23, 2020
Merged

rename hubble-proxy to hubble-relay #11122

merged 1 commit into from Apr 23, 2020

Conversation

rolinh
Copy link
Member

@rolinh rolinh commented Apr 23, 2020

The scope of this component goes beyond simply proxying requests.
As such, it was decided to rename it to "hubble-relay". This is what this commit does, without any functional changes.

@rolinh
rename hubble-proxy to hubble-relay
2fe1640 
The scope of this component goes beyond simply proxying requests.
As such, it was decided to rename it to "hubble-relay". This is what
this commit does, without any functional changes.

Signed-off-by: Robin Hahling <robin.hahling@gw-computing.net>
@rolinh rolinh added release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay labels Apr 23, 2020
@rolinh rolinh requested a review from a team April 23, 2020 14:03
@rolinh rolinh requested a review from a team as a code owner April 23, 2020 14:03
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 23, 2020
gandro
gandro approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛰️

@rolinh
Copy link
Member Author

rolinh commented Apr 23, 2020

It looks like github action is suffering from ongoing github infrastructure issues:

Prepare workflow directory
Prepare all required actions
Download action repository 'actions/checkout@v1'
##[warning]Failed to download action 'https://api.github.com/repos/actions/checkout/tarball/v1'. Error Response status code does not indicate success: 500 (Internal Server Error).
##[warning]Back off 17.72 seconds before retry.
##[warning]Failed to download action 'https://api.github.com/repos/actions/checkout/tarball/v1'. Error Response status code does not indicate success: 500 (Internal Server Error).
##[warning]Back off 27.119 seconds before retry.
##[error]Response status code does not indicate success: 500 (Internal Server Error).

@pchaigno
Copy link
Member

Our GitHub action is only for documentation tests right now, so I think we can ignore it since this pull request doesn't change documentation.

@pchaigno
Copy link
Member

test-me-please

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 44.708% when pulling 2fe1640 on pr/rolinh/rename-hubble-proxy-to-relay into 78e703c on master.

@christarazi
Copy link
Member

Looks like the GKE test flaked? Do we need this to pass or can I just merge?

@rolinh
Copy link
Member Author

rolinh commented Apr 23, 2020

@christarazi I think it's OK to just merge.

@christarazi christarazi merged commit 01be34a into master Apr 23, 2020
1.8.0 automation moved this from In progress to Merged Apr 23, 2020
@christarazi christarazi deleted the pr/rolinh/rename-hubble-proxy-to-relay branch April 23, 2020 18:53
@tklauser tklauser mentioned this pull request Apr 27, 2020
Merged
tklauser added a commit that referenced this pull request Apr 27, 2020
@tklauser
make: fix govet target after renaming hubble-proxy to hubble-relay
e7a647f 
hubble-proxy was renamed to hubble-relay in #11122, adjust its name in
the `govet` list as well.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
qmonnet pushed a commit that referenced this pull request Apr 28, 2020
@tklauser @qmonnet
make: fix govet target after renaming hubble-proxy to hubble-relay
aa870cd 
hubble-proxy was renamed to hubble-relay in #11122, adjust its name in
the `govet` list as well.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@glibsm glibsm glibsm approved these changes

@pchaigno pchaigno pchaigno approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rolinh @pchaigno @coveralls @christarazi @gandro @glibsm @michi-covalent