Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: fix govet target after renaming hubble-proxy to hubble-relay #11178

Merged
merged 1 commit into from Apr 28, 2020

Conversation

tklauser
Copy link
Member

hubble-proxy was renamed to hubble-relay in #11122, adjust its name in
the govet list as well.

@tklauser tklauser added pending-review release-note/misc This PR makes changes that have no direct user impact. labels Apr 27, 2020
@tklauser tklauser requested a review from a team April 27, 2020 16:12
@tklauser tklauser requested a review from a team as a code owner April 27, 2020 16:12
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 27, 2020
@tklauser tklauser changed the title make: fix govet target after rename of hubble-proxy to hubble-relay make: fix govet target after renaming hubble-proxy to hubble-relay Apr 27, 2020
hubble-proxy was renamed to hubble-relay in #11122, adjust its name in
the `govet` list as well.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser force-pushed the pr/tklauser/makefile-vet-hubble-relay branch from 70afa3c to e7a647f Compare April 27, 2020 16:12
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this one... Thanks for the fix!

@rolinh rolinh added the sig/hubble Impacts hubble server or relay label Apr 27, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 44.78% when pulling e7a647f on pr/tklauser/makefile-vet-hubble-relay into eeb182b on master.

@aanm aanm added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 27, 2020
@qmonnet qmonnet merged commit aa870cd into master Apr 28, 2020
1.8.0 automation moved this from In progress to Merged Apr 28, 2020
@qmonnet qmonnet deleted the pr/tklauser/makefile-vet-hubble-relay branch April 28, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay
Projects
No open projects
1.8.0
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

8 participants