Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Allow kubectl label node to overwrite #11182

Merged
merged 1 commit into from Apr 28, 2020
Merged

test: Allow kubectl label node to overwrite #11182

merged 1 commit into from Apr 28, 2020

Conversation

jrajahalme
Copy link
Member

Sometimes cluster selection for GKE fails like so:

13:31:10 labeling nodes
13:31:11 error: 'cilium.io/ci-node' already has a value (k8s1), and --overwrite is false

Add the '--overwrite' option to allow re-labeling of a node.

Signed-off-by: Jarno Rajahalme jarno@covalent.io

@jrajahalme
test: Allow kubectl label node to overwrite
1f54211 
Sometimes cluster selection for GKE fails like so:

13:31:10  labeling nodes
13:31:11  error: 'cilium.io/ci-node' already has a value (k8s1), and --overwrite is false

Add the '--overwrite' option to allow re-labeling of a node.

Signed-off-by: Jarno Rajahalme <jarno@covalent.io>
@jrajahalme jrajahalme added kind/bug/CI This is a bug in the testing code. area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/misc This PR makes changes that have no direct user impact. labels Apr 27, 2020
@jrajahalme jrajahalme requested a review from a team as a code owner April 27, 2020 21:43
@maintainer-s-little-helper maintainer-s-little-helper bot added this to In progress in 1.8.0 Apr 27, 2020
@jrajahalme
Copy link
Member Author

test-gke

@jrajahalme jrajahalme mentioned this pull request Apr 27, 2020
Merged
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 44.774% when pulling 1f54211 on pr/jrajahalme/test-label-nodes-allow-overwrite into e7d4f5c on master.

tgraf
tgraf approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@tgraf tgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #11167, we should be able to remove this during select altogether.

@nebril nebril merged commit ebe156f into master Apr 28, 2020
1.8.0 automation moved this from In progress to Merged Apr 28, 2020
@nebril nebril deleted the pr/jrajahalme/test-label-nodes-allow-overwrite branch April 28, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

@tgraf tgraf tgraf approved these changes

Assignees
No one assigned
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow kind/bug/CI This is a bug in the testing code. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.8.0
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jrajahalme @coveralls @nebril @tgraf