hubble: Use a single string to configure the server address #11330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michi-covalent
added
release-note/misc
|
Added another commit to to change hubble-ui to connect to hubble-relay. |
rolinh
requested changes
May 5, 2020
tklauser
reviewed
May 5, 2020
michi-covalent
force-pushed
the
pr/michi/address
branch
2 times, most recently
from
bc6007c
to
9deccf9
Compare
rolinh
reviewed
May 6, 2020
michi-covalent
force-pushed
the
pr/michi/address
branch
from
9deccf9
to
96fabbc
Compare
|
hm i think i broke something. fixing now |
michi-covalent
force-pushed
the
pr/michi/address
branch
from
96fabbc
to
6178aff
Compare
|
ready for review cc @rolinh |
|
test-me-please |
1 similar comment
|
test-me-please |
aanm
approved these changes
May 7, 2020
|
restart-ginkgo |
|
Commit abc0caf202b7d10c8b6d31ac7b4fdbf91f791c33 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
michi-covalent
force-pushed
the
pr/michi/address
branch
from
abc0caf
to
4609feb
Compare
|
Commit abc0caf202b7d10c8b6d31ac7b4fdbf91f791c33 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
michi-covalent
removed
the
dont-merge/needs-sign-off
|
test-with-kernel |
rolinh
requested changes
May 8, 2020
- Rename the option to `--hubble-listen-address` to make it clear that
Hubble listens to at most one additional address.
- Remove an info message that doesn't provide any addtional info:
```
level=info msg="Starting local Hubble server" address="unix:///var/run/cilium/hubble.sock" subsys=hubble
level=info msg="Starting Hubble server" address=":4244" subsys=hubble
- level=info msg="Starting gRPC server on listener" listener="unix:///var/run/cilium/hubble.sock" subsys=hubble
- level=info msg="Starting gRPC server on listener" listener=":4244" subsys=hubble
```
- Use port 4244 in the documentation since this is the port that Hubble
relay expects.
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
- Configure hubble-ui to connect to hubble-relay:80. Now hubble-relay is responsible for retrieving flows from Cilium instances. - Remove hubble-grpc service. Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
Now that Hubble has 1 unix domain socket and at most 1 TCP socket to
serve, we can simply use `With{UnixSocket,TCP}Listener` options.
Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
michi-covalent
force-pushed
the
pr/michi/address
branch
from
4609feb
to
5b6be3e
Compare
rolinh
approved these changes
May 8, 2020
|
The test failure is unrelated to the PR, should be fixed by #11427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--hubble-listen-addressto make it clear thatHubble listens to at most one additional address.
relay expects.
Signed-off-by: Michi Mutsuzaki michi@isovalent.com