Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hubble: Use a single string to configure the server address #11330

Merged
merged 3 commits into from May 8, 2020
Merged

hubble: Use a single string to configure the server address #11330

merged 3 commits into from May 8, 2020
+44 −97

Commits on May 8, 2020

  1. hubble: Use a single string to configure the server address 

    - Rename the option to `--hubble-listen-address` to make it clear that
  Hubble listens to at most one additional address.
- Remove an info message that doesn't provide any addtional info:
    ```
      level=info msg="Starting local Hubble server" address="unix:///var/run/cilium/hubble.sock" subsys=hubble
      level=info msg="Starting Hubble server" address=":4244" subsys=hubble
    - level=info msg="Starting gRPC server on listener" listener="unix:///var/run/cilium/hubble.sock" subsys=hubble
    - level=info msg="Starting gRPC server on listener" listener=":4244" subsys=hubble
    ```
- Use port 4244 in the documentation since this is the port that Hubble
  relay expects.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
    @michi-covalent
    michi-covalent committed May 8, 2020
    Configuration menu
    Copy the full SHA
    c1ed6d1 View commit details
    Browse the repository at this point in the history

  2. hubble: Point hubble-ui to hubble-relay service 

    - Configure hubble-ui to connect to hubble-relay:80. Now hubble-relay is
  responsible for retrieving flows from Cilium instances.
- Remove hubble-grpc service.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
    @michi-covalent
    michi-covalent committed May 8, 2020
    Configuration menu
    Copy the full SHA
    26a98b7 View commit details
    Browse the repository at this point in the history

  3. hubble: Remove serveroption.WithListeners 

    Now that Hubble has 1 unix domain socket and at most 1 TCP socket to
serve, we can simply use `With{UnixSocket,TCP}Listener` options.

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
    @michi-covalent
    michi-covalent committed May 8, 2020
    Configuration menu
    Copy the full SHA
    5b6be3e View commit details
    Browse the repository at this point in the history