test: Don't delete and redeploy Cilium at end of test context #11602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please set the appropriate release note label. |
tgraf
added
the
release-note/misc
tgraf
force-pushed
the
pr/tgraf/ci-dont-uninstall-cilium-at-end-of-test
branch
from
d628dd4
to
17c4f9b
Compare
|
test-me-please |
tgraf
added
the
ci/flake
tgraf
changed the title
brb
approved these changes
May 20, 2020
pchaigno
reviewed
May 20, 2020
There is no point in doing this. Each test context will deploy Cilium in BeforeAll() with the required configuration. Signed-off-by: Thomas Graf <thomas@cilium.io>
tgraf
force-pushed
the
pr/tgraf/ci-dont-uninstall-cilium-at-end-of-test
branch
from
17c4f9b
to
9933a52
Compare
|
retest-net-next |
qmonnet
added a commit
that referenced
this pull request
May 22, 2020
In #11602, Cilium redeployment was removed from most of the AfterAll() steps in the tests. It could not be removed in one case in the Service tests, because running IPv4 fragment tracking tests with the options used to deploy Cilium in the previous test make them fail. Deploy Cilium with a clean configuration before running the fragment tracking tests, and remove redeployment from that AfterAll() block at last. Signed-off-by: Quentin Monnet <quentin@isovalent.com>
joestringer
pushed a commit
that referenced
this pull request
May 26, 2020
In #11602, Cilium redeployment was removed from most of the AfterAll() steps in the tests. It could not be removed in one case in the Service tests, because running IPv4 fragment tracking tests with the options used to deploy Cilium in the previous test make them fail. Deploy Cilium with a clean configuration before running the fragment tracking tests, and remove redeployment from that AfterAll() block at last. Signed-off-by: Quentin Monnet <quentin@isovalent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.