test/K8sServices: redeploy Cilium before fragment tracking tests #11663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #11602, Cilium redeployment was removed from most of the AfterAll() steps in the tests. It could not be removed in one case in the Service tests, because running IPv4 fragment tracking tests with the options used to deploy Cilium in the previous test make them fail. Deploy Cilium with a clean configuration before running the fragment tracking tests, and remove redeployment from that AfterAll() block at last. Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
added
pending-review
area/CI
|
test-me-please |
michi-covalent
approved these changes
May 22, 2020
pchaigno
approved these changes
May 23, 2020
|
retest-net-next |
|
retest-runtime |
qmonnet
added
ready-to-merge
joestringer
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #11602, Cilium redeployment was removed from most of the
AfterAll()steps in the tests. It could not be removed in one case in the Services tests, because running IPv4 fragment tracking tests with the options used to deploy Cilium in the previous test make them fail.Deploy Cilium with a clean configuration before running the fragment tracking tests, and remove redeployment from that
AfterAll()block at last.